Testing commons-lang2 removal from jenkins-core

[alecharp]

This is simply to validate / see what breaks with the removal of the library from Jenkins Core.
See jenkinsci/jenkins#26105.

[MarkEWaite]

Can update to a more recent incremental of Jenkins core.

[timja]

I tried using openrewrite but neither the commons-lang3-api recipe or openrewrite cli seemed to do anything for me.

Gave up and just did:

rg -0 -lF 'org.apache.commons.lang.' . |
while IFS= read -r -d '' file; do
  sed -i '' 's/org.apache.commons.lang/org.apache.commons.lang3/' "$file"
done

Added the dep:

        <dependency>
            <groupId>io.jenkins.plugins</groupId>
            <artifactId>commons-lang3-api</artifactId>
        </dependency>

Banned commons-lang2:

<ban-commons-lang-2.skip>false</ban-commons-lang-2.skip>

Would be nice if there was a command that could be run to just do it.
Or migrate to Java platform API...

• Remove commons-lang2 azure-storage-plugin#412
• Use commons-lang3 API plugin azure-credentials-plugin#354

[timja]

@jonesbusy any idea what I was missing above? I would have thought there should be a simple method of migrating commons-lang to either java APIs or to commons-lang3

[jonesbusy]

@jonesbusy any idea what I was missing above? I would have thought there should be a simple method of migrating commons-lang to either java APIs or to commons-lang3

Any error in particular?

There is a recipe that change to commons-lang3 plugin-modernizer dry-run --plugins <plugin> --recipe MigrateCommonsLang2ToLang3AndCommonText that I was using of quiet a few plugins

For native Java API it's tracked by jenkins-infra/plugin-modernizer-tool#1542

It's probably just reusing what is provided by OpenRewrite

EDIT: Not sure if related by last with infra incident but some URL that we were using to get installation data return 404

        at io.jenkins.tools.pluginmodernizer.cli.Main.main(Main.java:50)
Caused by: io.jenkins.tools.pluginmodernizer.core.model.ModernizerException: Failed to get CSV data. Received response code: 404 from https://stats.jenkins.io/jenkins-stats/svg/202505-plugins.csv
        at io.jenkins.tools.pluginmodernizer.core.utils.CSVUtils.fromUrl(CSVUtils.java:40)

I will publish a release that ignore installation stats for now