Merged
Conversation
This is an undeclared library, coming from core, which we need to remove
alecharp
added a commit
to alecharp/bom
that referenced
this pull request
Jan 14, 2026
Member
Author
|
cc @jenkinsci/opentelemetry-plugin-developers |
kuisathaverat
approved these changes
Jan 16, 2026
Member
Author
|
A release is needed. |
Contributor
I know it, I do not think the change is worth a release. |
Member
Author
without a release, it means we cannot plan to remove completely the library from Jenkins Core. |
Comment on lines
+156
to
+159
| <dependency> | ||
| <groupId>io.jenkins.plugins</groupId> | ||
| <artifactId>commons-lang3-api</artifactId> | ||
| </dependency> |
Contributor
There was a problem hiding this comment.
@alecharp Spotless remove this dependency when you run mvn spotless:apply that means it is already provided, would this change in the BOM?
Member
Author
There was a problem hiding this comment.
it doesn't remove it, it moved it, no?
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an undeclared library, coming from core, which we need to remove.
See jenkinsci/jenkins#26105 and jenkinsci/bom#6234
Testing done
mvn test-compilewithout problem. Relying on CI for the rest.Submitter checklist