-
Notifications
You must be signed in to change notification settings - Fork 77
Ban Commons Lang 2 #1213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ban Commons Lang 2 #1213
Conversation
This is an undeclared library, coming from core, which we need to remove
|
cc @jenkinsci/opentelemetry-plugin-developers |
|
A release is needed. |
I know it, I do not think the change is worth a release. |
without a release, it means we cannot plan to remove completely the library from Jenkins Core. |
| <dependency> | ||
| <groupId>io.jenkins.plugins</groupId> | ||
| <artifactId>commons-lang3-api</artifactId> | ||
| </dependency> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alecharp Spotless remove this dependency when you run mvn spotless:apply that means it is already provided, would this change in the BOM?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it doesn't remove it, it moved it, no?
This is an undeclared library, coming from core, which we need to remove.
See jenkinsci/jenkins#26105 and jenkinsci/bom#6234
Testing done
mvn test-compilewithout problem. Relying on CI for the rest.Submitter checklist