Remove ChildNameGenerator.CHILD_NAME_FILE#483
Merged
basil merged 3 commits intojenkinsci:masterfrom Jul 9, 2025
Merged
Conversation
basil
force-pushed
the
child-name-file
branch
2 times, most recently
from
765ca0f to
263cce8
Compare
Merged
6 tasks
basil
changed the title
ChildNameGenerator.CHILD_NAME_FILE can be removedChildNameGenerator.CHILD_NAME_FILE
jglick
reviewed
Apr 10, 2025
src/main/java/com/cloudbees/hudson/plugins/folder/AbstractFolder.java
Outdated
Show resolved
Hide resolved
jglick
reviewed
Apr 10, 2025
basil
force-pushed
the
child-name-file
branch
2 times, most recently
from
6d69714 to
acc7867
Compare
3 tasks
basil
added
github_actions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completes the work started in #484 by completely removing any references to
CHILD_NAME_FILE. We don't bother to clean up any existing files that already exist on the filesystem, but as of this PR we neither read any existingCHILD_NAME_FILEs nor do we write any new ones. This PR depends on:ChildNameGenerator.CHILD_NAME_FILEbranch-api-plugin#512 being merged, released, and adoptedChildNameGenerator#CHILD_NAME_FILE#484 to make sure we fully understand the problem and can trust the replacement computation.