Skip to content

chore: allow to differenciate JDKs to build depending on Jenkins release line#2178

Merged
lemeurherve merged 15 commits intojenkinsci:masterfrom
lemeurherve:docker-2.545-no-jdk17
Jan 8, 2026
Merged

chore: allow to differenciate JDKs to build depending on Jenkins release line#2178
lemeurherve merged 15 commits intojenkinsci:masterfrom
lemeurherve:docker-2.545-no-jdk17

Conversation

@lemeurherve
Copy link
Member

@lemeurherve lemeurherve commented Jan 7, 2026

This PR allows to differenciate JDKs to build depending on Jenkins release line, to allow publishing both Weekly and LTS from the same source code even when their JDK requirements diverge for a while during JDK depreciations in Jenkins Core.

It also removes JDK17 from the JDKs to build for the Weekly releases as 2.545 now requires JDK21 while the incoming LTS 2.541.1 won't.
EDIT: in a follow-up PR, different concern, see #2178 (comment)

Refs:

Testing done

make build

make show
{
  "group": {
    "alpine": {
      "targets": [
        "alpine_jdk21",
        "alpine_jdk25"
      ]
    },
    "debian": {
      "targets": [
        "debian_jdk21",
        "debian_jdk25",
        "debian-slim_jdk21",
        "debian-slim_jdk25"
      ]
    },
    "default": {
      "targets": [
        "linux"
      ]
    },
    "linux": {
      "targets": [
        "alpine",
        "debian",
        "rhel"
      ]
    },
    "rhel": {
      "targets": [
        "rhel_jdk21",
        "rhel_jdk25"
      ]
    }
  },
  "target": {
    "alpine_jdk21": {
      "context": ".",
      "dockerfile": "alpine/hotspot/Dockerfile",
      "args": {
        "ALPINE_TAG": "3.23.2",
        "COMMIT_SHA": "c23ccd0d689b05f8110b0d857da9fd64046b8fb4",
        "JAVA_VERSION": "21.0.9_10",
        "JENKINS_VERSION": "2.534",
        "PLUGIN_CLI_VERSION": "2.13.2",
        "WAR_SHA": "fcf13a8ebbe69d678608cc4b3885ece7d7e697d6da4c3691025a06968ddef228",
        "WAR_URL": "https://get.jenkins.io/war/2.534/jenkins.war"
      },
      "tags": [
        "docker.io/jenkins/jenkins:2.534-alpine-jdk21",
        "docker.io/jenkins/jenkins:2.534-alpine"
      ],
      "platforms": [
        "linux/amd64",
        "linux/arm64"
      ],
      "output": [
        {
          "type": "docker"
        }
      ]
    },
    "alpine_jdk25": {
      "context": ".",
      "dockerfile": "alpine/hotspot/Dockerfile",
      "args": {
        "ALPINE_TAG": "3.23.2",
        "COMMIT_SHA": "c23ccd0d689b05f8110b0d857da9fd64046b8fb4",
        "JAVA_VERSION": "25.0.1_8",
        "JENKINS_VERSION": "2.534",
        "PLUGIN_CLI_VERSION": "2.13.2",
        "WAR_SHA": "fcf13a8ebbe69d678608cc4b3885ece7d7e697d6da4c3691025a06968ddef228",
        "WAR_URL": "https://get.jenkins.io/war/2.534/jenkins.war"
      },
      "tags": [
        "docker.io/jenkins/jenkins:2.534-alpine-jdk25"
      ],
      "platforms": [
        "linux/amd64",
        "linux/arm64"
      ],
      "output": [
        {
          "type": "docker"
        }
      ]
    },
    "debian-slim_jdk21": {
      "context": ".",
      "dockerfile": "debian/Dockerfile",
      "args": {
        "COMMIT_SHA": "c23ccd0d689b05f8110b0d857da9fd64046b8fb4",
        "DEBIAN_RELEASE_LINE": "trixie",
        "DEBIAN_VARIANT": "-slim",
        "DEBIAN_VERSION": "20251117",
        "JAVA_VERSION": "21.0.9_10",
        "JENKINS_VERSION": "2.534",
        "PLUGIN_CLI_VERSION": "2.13.2",
        "WAR_SHA": "fcf13a8ebbe69d678608cc4b3885ece7d7e697d6da4c3691025a06968ddef228",
        "WAR_URL": "https://get.jenkins.io/war/2.534/jenkins.war"
      },
      "tags": [
        "docker.io/jenkins/jenkins:2.534-slim-jdk21",
        "docker.io/jenkins/jenkins:2.534-slim"
      ],
      "platforms": [
        "linux/amd64",
        "linux/arm64"
      ],
      "output": [
        {
          "type": "docker"
        }
      ]
    },
    "debian-slim_jdk25": {
      "context": ".",
      "dockerfile": "debian/Dockerfile",
      "args": {
        "COMMIT_SHA": "c23ccd0d689b05f8110b0d857da9fd64046b8fb4",
        "DEBIAN_RELEASE_LINE": "trixie",
        "DEBIAN_VARIANT": "-slim",
        "DEBIAN_VERSION": "20251117",
        "JAVA_VERSION": "25.0.1_8",
        "JENKINS_VERSION": "2.534",
        "PLUGIN_CLI_VERSION": "2.13.2",
        "WAR_SHA": "fcf13a8ebbe69d678608cc4b3885ece7d7e697d6da4c3691025a06968ddef228",
        "WAR_URL": "https://get.jenkins.io/war/2.534/jenkins.war"
      },
      "tags": [
        "docker.io/jenkins/jenkins:2.534-slim-jdk25"
      ],
      "platforms": [
        "linux/amd64",
        "linux/arm64"
      ],
      "output": [
        {
          "type": "docker"
        }
      ]
    },
    "debian_jdk21": {
      "context": ".",
      "dockerfile": "debian/Dockerfile",
      "args": {
        "COMMIT_SHA": "c23ccd0d689b05f8110b0d857da9fd64046b8fb4",
        "DEBIAN_RELEASE_LINE": "trixie",
        "DEBIAN_VARIANT": "",
        "DEBIAN_VERSION": "20251117",
        "JAVA_VERSION": "21.0.9_10",
        "JENKINS_VERSION": "2.534",
        "PLUGIN_CLI_VERSION": "2.13.2",
        "WAR_SHA": "fcf13a8ebbe69d678608cc4b3885ece7d7e697d6da4c3691025a06968ddef228",
        "WAR_URL": "https://get.jenkins.io/war/2.534/jenkins.war"
      },
      "tags": [
        "docker.io/jenkins/jenkins:2.534-jdk21",
        "docker.io/jenkins/jenkins:2.534"
      ],
      "platforms": [
        "linux/amd64",
        "linux/arm64",
        "linux/s390x",
        "linux/ppc64le"
      ],
      "output": [
        {
          "type": "docker"
        }
      ]
    },
    "debian_jdk25": {
      "context": ".",
      "dockerfile": "debian/Dockerfile",
      "args": {
        "COMMIT_SHA": "c23ccd0d689b05f8110b0d857da9fd64046b8fb4",
        "DEBIAN_RELEASE_LINE": "trixie",
        "DEBIAN_VARIANT": "",
        "DEBIAN_VERSION": "20251117",
        "JAVA_VERSION": "25.0.1_8",
        "JENKINS_VERSION": "2.534",
        "PLUGIN_CLI_VERSION": "2.13.2",
        "WAR_SHA": "fcf13a8ebbe69d678608cc4b3885ece7d7e697d6da4c3691025a06968ddef228",
        "WAR_URL": "https://get.jenkins.io/war/2.534/jenkins.war"
      },
      "tags": [
        "docker.io/jenkins/jenkins:2.534-jdk25"
      ],
      "platforms": [
        "linux/amd64",
        "linux/arm64",
        "linux/s390x",
        "linux/ppc64le"
      ],
      "output": [
        {
          "type": "docker"
        }
      ]
    },
    "rhel_jdk21": {
      "context": ".",
      "dockerfile": "rhel/Dockerfile",
      "args": {
        "COMMIT_SHA": "c23ccd0d689b05f8110b0d857da9fd64046b8fb4",
        "JAVA_VERSION": "21.0.9_10",
        "JENKINS_VERSION": "2.534",
        "PLUGIN_CLI_VERSION": "2.13.2",
        "RHEL_RELEASE_LINE": "ubi9",
        "RHEL_TAG": "9.7-1767674301",
        "WAR_SHA": "fcf13a8ebbe69d678608cc4b3885ece7d7e697d6da4c3691025a06968ddef228",
        "WAR_URL": "https://get.jenkins.io/war/2.534/jenkins.war"
      },
      "tags": [
        "docker.io/jenkins/jenkins:2.534-rhel-ubi9-jdk21"
      ],
      "platforms": [
        "linux/amd64",
        "linux/arm64",
        "linux/ppc64le"
      ],
      "output": [
        {
          "type": "docker"
        }
      ]
    },
    "rhel_jdk25": {
      "context": ".",
      "dockerfile": "rhel/Dockerfile",
      "args": {
        "COMMIT_SHA": "c23ccd0d689b05f8110b0d857da9fd64046b8fb4",
        "JAVA_VERSION": "25.0.1_8",
        "JENKINS_VERSION": "2.534",
        "PLUGIN_CLI_VERSION": "2.13.2",
        "RHEL_RELEASE_LINE": "ubi9",
        "RHEL_TAG": "9.7-1767674301",
        "WAR_SHA": "fcf13a8ebbe69d678608cc4b3885ece7d7e697d6da4c3691025a06968ddef228",
        "WAR_URL": "https://get.jenkins.io/war/2.534/jenkins.war"
      },
      "tags": [
        "docker.io/jenkins/jenkins:2.534-rhel-ubi9-jdk25"
      ],
      "platforms": [
        "linux/amd64",
        "linux/arm64",
        "linux/ppc64le"
      ],
      "output": [
        {
          "type": "docker"
        }
      ]
    }
  }
}
JENKINS_VERSION=2.541.1 make show
{
  "group": {
    "alpine": {
      "targets": [
        "alpine_jdk17",
        "alpine_jdk21",
        "alpine_jdk25"
      ]
    },
    "debian": {
      "targets": [
        "debian_jdk17",
        "debian_jdk21",
        "debian_jdk25",
        "debian-slim_jdk17",
        "debian-slim_jdk21",
        "debian-slim_jdk25"
      ]
    },
    "default": {
      "targets": [
        "linux"
      ]
    },
    "linux": {
      "targets": [
        "alpine",
        "debian",
        "rhel"
      ]
    },
    "rhel": {
      "targets": [
        "rhel_jdk17",
        "rhel_jdk21",
        "rhel_jdk25"
      ]
    }
  },
  "target": {
    "alpine_jdk17": {
      "context": ".",
      "dockerfile": "alpine/hotspot/Dockerfile",
      "args": {
        "ALPINE_TAG": "3.23.2",
        "COMMIT_SHA": "c23ccd0d689b05f8110b0d857da9fd64046b8fb4",
        "JAVA_VERSION": "17.0.17_10",
        "JENKINS_VERSION": "2.541.1",
        "PLUGIN_CLI_VERSION": "2.13.2",
        "WAR_SHA": "fcf13a8ebbe69d678608cc4b3885ece7d7e697d6da4c3691025a06968ddef228",
        "WAR_URL": "https://get.jenkins.io/war-stable/2.541.1/jenkins.war"
      },
      "tags": [
        "docker.io/jenkins/jenkins:2.541.1-alpine-jdk17"
      ],
      "platforms": [
        "linux/amd64"
      ],
      "output": [
        {
          "type": "docker"
        }
      ]
    },
    "alpine_jdk21": {
      "context": ".",
      "dockerfile": "alpine/hotspot/Dockerfile",
      "args": {
        "ALPINE_TAG": "3.23.2",
        "COMMIT_SHA": "c23ccd0d689b05f8110b0d857da9fd64046b8fb4",
        "JAVA_VERSION": "21.0.9_10",
        "JENKINS_VERSION": "2.541.1",
        "PLUGIN_CLI_VERSION": "2.13.2",
        "WAR_SHA": "fcf13a8ebbe69d678608cc4b3885ece7d7e697d6da4c3691025a06968ddef228",
        "WAR_URL": "https://get.jenkins.io/war-stable/2.541.1/jenkins.war"
      },
      "tags": [
        "docker.io/jenkins/jenkins:2.541.1-alpine-jdk21",
        "docker.io/jenkins/jenkins:2.541.1-alpine"
      ],
      "platforms": [
        "linux/amd64",
        "linux/arm64"
      ],
      "output": [
        {
          "type": "docker"
        }
      ]
    },
    "alpine_jdk25": {
      "context": ".",
      "dockerfile": "alpine/hotspot/Dockerfile",
      "args": {
        "ALPINE_TAG": "3.23.2",
        "COMMIT_SHA": "c23ccd0d689b05f8110b0d857da9fd64046b8fb4",
        "JAVA_VERSION": "25.0.1_8",
        "JENKINS_VERSION": "2.541.1",
        "PLUGIN_CLI_VERSION": "2.13.2",
        "WAR_SHA": "fcf13a8ebbe69d678608cc4b3885ece7d7e697d6da4c3691025a06968ddef228",
        "WAR_URL": "https://get.jenkins.io/war-stable/2.541.1/jenkins.war"
      },
      "tags": [
        "docker.io/jenkins/jenkins:2.541.1-alpine-jdk25"
      ],
      "platforms": [
        "linux/amd64",
        "linux/arm64"
      ],
      "output": [
        {
          "type": "docker"
        }
      ]
    },
    "debian-slim_jdk17": {
      "context": ".",
      "dockerfile": "debian/Dockerfile",
      "args": {
        "COMMIT_SHA": "c23ccd0d689b05f8110b0d857da9fd64046b8fb4",
        "DEBIAN_RELEASE_LINE": "trixie",
        "DEBIAN_VARIANT": "-slim",
        "DEBIAN_VERSION": "20251117",
        "JAVA_VERSION": "17.0.17_10",
        "JENKINS_VERSION": "2.541.1",
        "PLUGIN_CLI_VERSION": "2.13.2",
        "WAR_SHA": "fcf13a8ebbe69d678608cc4b3885ece7d7e697d6da4c3691025a06968ddef228",
        "WAR_URL": "https://get.jenkins.io/war-stable/2.541.1/jenkins.war"
      },
      "tags": [
        "docker.io/jenkins/jenkins:2.541.1-slim-jdk17"
      ],
      "platforms": [
        "linux/amd64"
      ],
      "output": [
        {
          "type": "docker"
        }
      ]
    },
    "debian-slim_jdk21": {
      "context": ".",
      "dockerfile": "debian/Dockerfile",
      "args": {
        "COMMIT_SHA": "c23ccd0d689b05f8110b0d857da9fd64046b8fb4",
        "DEBIAN_RELEASE_LINE": "trixie",
        "DEBIAN_VARIANT": "-slim",
        "DEBIAN_VERSION": "20251117",
        "JAVA_VERSION": "21.0.9_10",
        "JENKINS_VERSION": "2.541.1",
        "PLUGIN_CLI_VERSION": "2.13.2",
        "WAR_SHA": "fcf13a8ebbe69d678608cc4b3885ece7d7e697d6da4c3691025a06968ddef228",
        "WAR_URL": "https://get.jenkins.io/war-stable/2.541.1/jenkins.war"
      },
      "tags": [
        "docker.io/jenkins/jenkins:2.541.1-slim-jdk21",
        "docker.io/jenkins/jenkins:2.541.1-slim"
      ],
      "platforms": [
        "linux/amd64",
        "linux/arm64"
      ],
      "output": [
        {
          "type": "docker"
        }
      ]
    },
    "debian-slim_jdk25": {
      "context": ".",
      "dockerfile": "debian/Dockerfile",
      "args": {
        "COMMIT_SHA": "c23ccd0d689b05f8110b0d857da9fd64046b8fb4",
        "DEBIAN_RELEASE_LINE": "trixie",
        "DEBIAN_VARIANT": "-slim",
        "DEBIAN_VERSION": "20251117",
        "JAVA_VERSION": "25.0.1_8",
        "JENKINS_VERSION": "2.541.1",
        "PLUGIN_CLI_VERSION": "2.13.2",
        "WAR_SHA": "fcf13a8ebbe69d678608cc4b3885ece7d7e697d6da4c3691025a06968ddef228",
        "WAR_URL": "https://get.jenkins.io/war-stable/2.541.1/jenkins.war"
      },
      "tags": [
        "docker.io/jenkins/jenkins:2.541.1-slim-jdk25"
      ],
      "platforms": [
        "linux/amd64",
        "linux/arm64"
      ],
      "output": [
        {
          "type": "docker"
        }
      ]
    },
    "debian_jdk17": {
      "context": ".",
      "dockerfile": "debian/Dockerfile",
      "args": {
        "COMMIT_SHA": "c23ccd0d689b05f8110b0d857da9fd64046b8fb4",
        "DEBIAN_RELEASE_LINE": "trixie",
        "DEBIAN_VARIANT": "",
        "DEBIAN_VERSION": "20251117",
        "JAVA_VERSION": "17.0.17_10",
        "JENKINS_VERSION": "2.541.1",
        "PLUGIN_CLI_VERSION": "2.13.2",
        "WAR_SHA": "fcf13a8ebbe69d678608cc4b3885ece7d7e697d6da4c3691025a06968ddef228",
        "WAR_URL": "https://get.jenkins.io/war-stable/2.541.1/jenkins.war"
      },
      "tags": [
        "docker.io/jenkins/jenkins:2.541.1-jdk17"
      ],
      "platforms": [
        "linux/amd64",
        "linux/arm64",
        "linux/s390x",
        "linux/ppc64le"
      ],
      "output": [
        {
          "type": "docker"
        }
      ]
    },
    "debian_jdk21": {
      "context": ".",
      "dockerfile": "debian/Dockerfile",
      "args": {
        "COMMIT_SHA": "c23ccd0d689b05f8110b0d857da9fd64046b8fb4",
        "DEBIAN_RELEASE_LINE": "trixie",
        "DEBIAN_VARIANT": "",
        "DEBIAN_VERSION": "20251117",
        "JAVA_VERSION": "21.0.9_10",
        "JENKINS_VERSION": "2.541.1",
        "PLUGIN_CLI_VERSION": "2.13.2",
        "WAR_SHA": "fcf13a8ebbe69d678608cc4b3885ece7d7e697d6da4c3691025a06968ddef228",
        "WAR_URL": "https://get.jenkins.io/war-stable/2.541.1/jenkins.war"
      },
      "tags": [
        "docker.io/jenkins/jenkins:2.541.1-jdk21",
        "docker.io/jenkins/jenkins:2.541.1"
      ],
      "platforms": [
        "linux/amd64",
        "linux/arm64",
        "linux/s390x",
        "linux/ppc64le"
      ],
      "output": [
        {
          "type": "docker"
        }
      ]
    },
    "debian_jdk25": {
      "context": ".",
      "dockerfile": "debian/Dockerfile",
      "args": {
        "COMMIT_SHA": "c23ccd0d689b05f8110b0d857da9fd64046b8fb4",
        "DEBIAN_RELEASE_LINE": "trixie",
        "DEBIAN_VARIANT": "",
        "DEBIAN_VERSION": "20251117",
        "JAVA_VERSION": "25.0.1_8",
        "JENKINS_VERSION": "2.541.1",
        "PLUGIN_CLI_VERSION": "2.13.2",
        "WAR_SHA": "fcf13a8ebbe69d678608cc4b3885ece7d7e697d6da4c3691025a06968ddef228",
        "WAR_URL": "https://get.jenkins.io/war-stable/2.541.1/jenkins.war"
      },
      "tags": [
        "docker.io/jenkins/jenkins:2.541.1-jdk25"
      ],
      "platforms": [
        "linux/amd64",
        "linux/arm64",
        "linux/s390x",
        "linux/ppc64le"
      ],
      "output": [
        {
          "type": "docker"
        }
      ]
    },
    "rhel_jdk17": {
      "context": ".",
      "dockerfile": "rhel/Dockerfile",
      "args": {
        "COMMIT_SHA": "c23ccd0d689b05f8110b0d857da9fd64046b8fb4",
        "JAVA_VERSION": "17.0.17_10",
        "JENKINS_VERSION": "2.541.1",
        "PLUGIN_CLI_VERSION": "2.13.2",
        "RHEL_RELEASE_LINE": "ubi9",
        "RHEL_TAG": "9.7-1767674301",
        "WAR_SHA": "fcf13a8ebbe69d678608cc4b3885ece7d7e697d6da4c3691025a06968ddef228",
        "WAR_URL": "https://get.jenkins.io/war-stable/2.541.1/jenkins.war"
      },
      "tags": [
        "docker.io/jenkins/jenkins:2.541.1-rhel-ubi9-jdk17"
      ],
      "platforms": [
        "linux/amd64",
        "linux/arm64",
        "linux/ppc64le"
      ],
      "output": [
        {
          "type": "docker"
        }
      ]
    },
    "rhel_jdk21": {
      "context": ".",
      "dockerfile": "rhel/Dockerfile",
      "args": {
        "COMMIT_SHA": "c23ccd0d689b05f8110b0d857da9fd64046b8fb4",
        "JAVA_VERSION": "21.0.9_10",
        "JENKINS_VERSION": "2.541.1",
        "PLUGIN_CLI_VERSION": "2.13.2",
        "RHEL_RELEASE_LINE": "ubi9",
        "RHEL_TAG": "9.7-1767674301",
        "WAR_SHA": "fcf13a8ebbe69d678608cc4b3885ece7d7e697d6da4c3691025a06968ddef228",
        "WAR_URL": "https://get.jenkins.io/war-stable/2.541.1/jenkins.war"
      },
      "tags": [
        "docker.io/jenkins/jenkins:2.541.1-rhel-ubi9-jdk21"
      ],
      "platforms": [
        "linux/amd64",
        "linux/arm64",
        "linux/ppc64le"
      ],
      "output": [
        {
          "type": "docker"
        }
      ]
    },
    "rhel_jdk25": {
      "context": ".",
      "dockerfile": "rhel/Dockerfile",
      "args": {
        "COMMIT_SHA": "c23ccd0d689b05f8110b0d857da9fd64046b8fb4",
        "JAVA_VERSION": "25.0.1_8",
        "JENKINS_VERSION": "2.541.1",
        "PLUGIN_CLI_VERSION": "2.13.2",
        "RHEL_RELEASE_LINE": "ubi9",
        "RHEL_TAG": "9.7-1767674301",
        "WAR_SHA": "fcf13a8ebbe69d678608cc4b3885ece7d7e697d6da4c3691025a06968ddef228",
        "WAR_URL": "https://get.jenkins.io/war-stable/2.541.1/jenkins.war"
      },
      "tags": [
        "docker.io/jenkins/jenkins:2.541.1-rhel-ubi9-jdk25"
      ],
      "platforms": [
        "linux/amd64",
        "linux/arm64",
        "linux/ppc64le"
      ],
      "output": [
        {
          "type": "docker"
        }
      ]
    }
  }
}

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests that demonstrate the feature works or the issue is fixed

@lemeurherve lemeurherve changed the title feat: allow to differenciate JDKs to build depending on Jenkins version release line fix: allow to differenciate JDKs to build depending on Jenkins version release line Jan 7, 2026
@lemeurherve lemeurherve marked this pull request as ready for review January 7, 2026 16:01
@lemeurherve lemeurherve requested a review from a team as a code owner January 7, 2026 16:01
@@ -117,16 +117,12 @@ stage('Build') {

if (!infra.isTrusted()) {
def images = [

This comment was marked as resolved.

Copy link
Member Author

@lemeurherve lemeurherve Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: to be really strict, there should be a map for Weekly images, and another with LTS images to get a proper exhaustive simulated LTS build on ci.jenkins.io in all cases.

But since that diff (no simulated jdk17 LTS) would only occur when manually replaying a simulated build and while weekly and LTS don't have the same list of JDKs, I didn't bother.

Copy link
Member Author

@lemeurherve lemeurherve Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This new comment could also be extracted in another PR if needed as not directly related to this feature.

Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant we've wanted this for awhile, previously we've used a hacky LTS branch I think

@lemeurherve
Copy link
Member Author

lemeurherve commented Jan 7, 2026

Just missing that part for Windows to also benefit from this mechanism, cf #2121 (comment)

The last remaining bit I'd like to add in this repo to be like the agents ones: jenkinsci/docker-ssh-agent#426

@lemeurherve lemeurherve changed the title fix: allow to differenciate JDKs to build depending on Jenkins version release line feat: allow to differenciate JDKs to build depending on Jenkins release line Jan 7, 2026
@lemeurherve lemeurherve marked this pull request as draft January 7, 2026 17:41
@lemeurherve lemeurherve marked this pull request as ready for review January 7, 2026 17:55
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except maybe the title which should be a chore since you've split the JDK17 removal to another PR (e.g. in the current state - 046147d being the lats commit - this PR does not introduce any change in the image delivered on Tuesday / LTS release days to end users).

I've changed the labels (for release drafter) but I let you change the title before merging to avoid pondering with the squash merge feature.

@lemeurherve lemeurherve changed the title feat: allow to differenciate JDKs to build depending on Jenkins release line chore: allow to differenciate JDKs to build depending on Jenkins release line Jan 8, 2026
@lemeurherve lemeurherve merged commit 9b6c263 into jenkinsci:master Jan 8, 2026
16 checks passed
@lemeurherve lemeurherve deleted the docker-2.545-no-jdk17 branch January 8, 2026 10:33
@lemeurherve lemeurherve added into-lts This should be filed against an LTS branch and removed into-lts This should be filed against an LTS branch labels Jan 14, 2026
@lemeurherve
Copy link
Member Author

Cf #2212,

Weekly/LTS differenciation to be removed from master too

Since #2195 this differenciation mechanism isn't needed anymore:

docker/docker-bake.hcl

Lines 2 to 16 in 4bd9193

variable "jdks_to_build_for_lts" {
default = [17, 21, 25]
}
variable "jdks_to_build_for_weekly" {
default = [21, 25]
}
variable "windows_version_to_build_for_lts" {
default = ["windowsservercore-ltsc2019", "windowsservercore-ltsc2022"]
}
variable "windows_version_to_build_for_weekly" {
default = ["windowsservercore-ltsc2019", "windowsservercore-ltsc2022"]
}

To be replaced like in stable-2.541 branch:

variable "jdks_to_build" {
default = [17, 21, 25]
}
variable "windows_version_to_build" {
default = ["windowsservercore-ltsc2019", "windowsservercore-ltsc2022"]
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants