[JENKINS-75320] use the url for linking

[scherler]

See JENKINS-75320. when searching https://ci.jenkins.io//search/?q=junit the linking is wrong, adopt the new URL instead

Testing done

to test you need to create first a folder and then create a job (e.g. named 1) in the folder. then you need to request http://localhost:8080/search/?q=1 without the fix the link will point to http://localhost:8080/search/?q=folder+%C2%BB+1

Proposed changelog entries

• Fix search results URLs when using the old search implementation

Proposed changelog category

/label bug

Proposed upgrade guidelines

N/A

Submitter checklist

• The Jira issue, if it exists, is well-described.
• The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
• There is automated testing or an explanation as to why this change has no tests.
• New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
• New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
• New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
• For dependency updates, there are links to external changelogs and, if possible, full differentials.
• For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@mention @janfaracik @timja @daniel-beck @basil

Before the changes are marked as ready-for-merge:

Maintainer checklist

• There are at least two (2) approvals for the pull request and no outstanding requests for change.
• Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
• Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
• Proper changelog labels are set so that the changelog can be generated automatically.
• If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
• If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

[scherler]

/label bug

[janfaracik]

Tried it locally with a pipeline and it doesn't have /jenkins/ prefixed so its resulting in a 404.

[timja]

Since you've labelled it as a bug can you please add a changelog entry

[scherler]

@timja added an entry @janfaracik good catch, forgot about the possible rootUrl, cheers

[scherler]

@janfaracik @timja @daniel-beck @basil could you have a look?

[timja]

/label ready-for-merge

---

This PR is now ready for merge, after the upcoming security release we will merge it if there's no negative feedback.

Thanks!

[A1exKH]

LGTM.

[mawinter69]

When the rootURL is empty this leads to a url that starts with a double slash. This results in a url like https://design-library (see https://weekly.ci.jenkins.io/search/?q=g)
So when i.url starts with a slash it must be removed first. Not sure but it seems the url is always absolute with respect to the root url so just removing the slash in here might be enough.