Skip to content

[JENKINS-75320] use the url for linking #10308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
krisstern merged 13 commits into from
Apr 4, 2025
Merged

[JENKINS-75320] use the url for linking #10308

Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
089beb1
[JENKINS-75320] use the url for linking
scherler Feb 21, 2025
4ba461c
[JENKINS-75320] add prefix
scherler Feb 24, 2025
d9a1873
Merge branch 'master' into JENKINS-75320
scherler Feb 24, 2025
6045109
Merge branch 'master' into JENKINS-75320
scherler Feb 26, 2025
4d0b0e3
Trigger Build
scherler Mar 3, 2025
3af0b5a
Merge branch 'master' into JENKINS-75320
scherler Mar 17, 2025
e622ee7
Merge branch 'master' into JENKINS-75320
scherler Mar 18, 2025
3cddda6
Merge branch 'master' into JENKINS-75320
timja Mar 19, 2025
49b92c7
Merge branch 'master' into JENKINS-75320
scherler Mar 24, 2025
49612ee
Merge branch 'master' into JENKINS-75320
krisstern Mar 25, 2025
3350a65
Merge branch 'master' into JENKINS-75320
krisstern Apr 2, 2025
44207f9
Merge branch 'master' into JENKINS-75320
scherler Apr 2, 2025
92c4237
Merge branch 'master' into JENKINS-75320
krisstern Apr 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/src/main/resources/hudson/search/Search/search-failed.jelly
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ THE SOFTWARE.
<ol>
<j:forEach var="i" items="${items}">
<li id="item_${i.path}">
<a href="?q=${h.urlEncode(i.path)}">${i.path}</a>
<a href="${rootURL}/${i.url}">${i.path}</a>
Copy link
Copy Markdown
Contributor

@mawinter69 mawinter69 Jun 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the rootURL is empty this leads to a url that starts with a double slash. This results in a url like https://design-library (see https://weekly.ci.jenkins.io/search/?q=g)
So when i.url starts with a slash it must be removed first. Not sure but it seems the url is always absolute with respect to the root url so just removing the slash in here might be enough.

</li>
</j:forEach>
</ol>
Expand Down
Loading