Skip to content

Backporting for Jenkins 2.492.3 release candidate#10417

Merged
MarkEWaite merged 2 commits intojenkinsci:stable-2.492from
MarkEWaite:stable-2.492.3-backport-1-c
Mar 19, 2025
Merged

Backporting for Jenkins 2.492.3 release candidate#10417
MarkEWaite merged 2 commits intojenkinsci:stable-2.492from
MarkEWaite:stable-2.492.3-backport-1-c

Conversation

@MarkEWaite
Copy link
Copy Markdown
Contributor

@MarkEWaite MarkEWaite commented Mar 19, 2025

See:

Fixed
-----

JENKINS-75278           Minor                   2025-02-13 11:10
        User pages for users with '\' in the user name fail after upgrading to 2.479.1
        bug
        https://issues.jenkins.io/browse/JENKINS-75278           

JENKINS-75321           Minor                   2025-02-21 13:28
        "No builds" displayed for a brief time when loading build history
        bug
        https://issues.jenkins.io/browse/JENKINS-75321

Testing done

mvn clean verify passes with Java 21 on Linux

Interactive testing in my home lab checked the following scenarios:

  • Created a user "coleen-waite" and then edited the users.xml file to use coleen\waite as the username. Restarted Jenkins and logged in as the user coleen\waite. Launched many jobs as that user. Viewed the user account, preferences, security, and experiments pages. Confirmed that preferences could be changed and were honored
  • Launched jobs that tested many different git providers like Assembla, Beanstalk, Bitbucket, GitHub, GitLab, and Microsoft
  • Confirmed that the "No builds" was never displayed (needs a slower connection or longer response time to test it)

Proposed changelog entries

  • The Jira issue, if it exists, is well-described.
  • The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
  • There is automated testing or an explanation as to why this change has no tests.
  • New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
  • New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
  • New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
  • For dependency updates, there are links to external changelogs and, if possible, full differentials.
  • For new APIs and extension points, there is a link to at least one consumer.

Proposed changelog entries

N/A

Proposed upgrade guidelines

N/A

Desired reviewers

  • N/A

Before the changes are marked as ready-for-merge:

Maintainer checklist

  • There are at least two (2) approvals for the pull request and no outstanding requests for change.
  • Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
  • Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
  • Proper changelog labels are set so that the changelog can be generated automatically.
  • If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

Vlatombe and others added 2 commits March 18, 2025 18:00
…t of build history widget

(cherry picked from commit 5d65d11)
…fter upgrading to 2.479.1 (jenkinsci#10344)

Signed-off-by: Olivier Lamy <olamy@apache.org>
(cherry picked from commit 9f91315)
@MarkEWaite MarkEWaite added the into-lts This PR is filed against an LTS branch label Mar 19, 2025
@MarkEWaite
Copy link
Copy Markdown
Contributor Author

MarkEWaite commented Mar 19, 2025

The two test failures reported by the first run are flaky tests as reported by Launchable. Each of them have been failing in about 3% of all test runs in the last 30 days. I've started another test run.

defaultValueAlwaysAvailable

defaultValueAlwaysAvailable-launchable-flaky-test-report

disconnectNodeManyShouldSucceed

screencapture-app-launchableinc-organizations-jenkins-workspaces-jenkins-data-test-paths-class-hudson-cli-DisconnectNodeCommandTest-2025-03-18-21_45_45-edit

@gounthar
Copy link
Copy Markdown
Contributor

gounthar commented Mar 19, 2025

Thanks, Mark!
This time, we have different failures:

hudson.cli.DisconnectNodeCommandTest.disconnectNodeManyShouldFailIfANodeDoesNotExist
hudson.cli.DisconnectNodeCommandTest.disconnectNodeManyShouldSucceed

@gounthar
Copy link
Copy Markdown
Contributor

This branch, and the one I recreated with the same cherry picks, build well on my Oracle Cloud aarch64 machine:

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  03:05 h
[INFO] Finished at: 2025-03-19T12:02:35Z
[INFO] ------------------------------------------------------------------------

@MarkEWaite
Copy link
Copy Markdown
Contributor Author

I am merging this without waiting for ci.jenkins.io to complete successfully because we have two runs that only failed due to known flaky tests and the failures were different flakes in each of the two failures.

@gounthar has confirmed that tests pass on his aarch64 Linux machine. I've confirmed that tests pass on my amd64 Linux machine. Tests will also be run on the stable-2.492 when this merges and we'll retry builds on stable-2.492 as needed to get an incremental build that can be used as the release candidate.

@MarkEWaite MarkEWaite merged commit b613107 into jenkinsci:stable-2.492 Mar 19, 2025
11 of 14 checks passed
@MarkEWaite MarkEWaite deleted the stable-2.492.3-backport-1-c branch March 19, 2025 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

into-lts This PR is filed against an LTS branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants