Skip to content

[JENKINS-75461] add top button for hetero-list, e.g. "Add Parameter"#10432

Open
mawinter69 wants to merge 18 commits intojenkinsci:masterfrom
mawinter69:enable-top-button-for-heterolist
Open

[JENKINS-75461] add top button for hetero-list, e.g. "Add Parameter"#10432
mawinter69 wants to merge 18 commits intojenkinsci:masterfrom
mawinter69:enable-top-button-for-heterolist

Conversation

@mawinter69
Copy link
Contributor

@mawinter69 mawinter69 commented Mar 20, 2025

Adds the possibility in a hetero-list (and repeatableHeteroProperty) to add an additional dropdown button at the top of the list when there is at least one item.
This is useful when it is common to have several items in such a list and the items contain itself configuration.

Enable the flag for job parameters and build steps and post build actions in freestyle jobs.

image

fixes #16687

Testing done

Testing Add build step

  1. created a freestyle project and added a step -> the top button appears
  2. added another step with the top button -> step is added to the top
  3. added another step with the bottom button -> step is added at the end
  4. removed the last step -> the top button disappears
  5. create a step that contains inside its configuration another hetero-list and added one item (used the conditional build step plugin for this)
  6. removing such an inner item has no influence on the outer hetero-list button

Tested Job Parameters and works as expcted

Testing Add post-build action the position where the new item is added is identical for top and bottom button due to honorOrder

Proposed changelog entries

  • add top button for hetero-list, e.g. "Add Parameter"

Proposed changelog category

/label developer,rfe,web-ui

Proposed upgrade guidelines

N/A

Submitter checklist

  • The Jira issue, if it exists, is well-described.
  • The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
  • There is automated testing or an explanation as to why this change has no tests.
  • New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
  • New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
  • New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
  • For dependency updates, there are links to external changelogs and, if possible, full differentials.
  • For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

  • There are at least two (2) approvals for the pull request and no outstanding requests for change.
  • Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
  • Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
  • Proper changelog labels are set so that the changelog can be generated automatically.
  • If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

Adds a dropdown for adding items to a hetero-list to the top of the list
when there is at least one item.
This is useful when the it is common to have several items in such a
list and the items contain itself configuration.

Enable the flag for job parameters and build steps and post build
actions in freestyle jobs.
@comment-ops-bot comment-ops-bot bot added developer Changes which impact plugin developers web-ui The PR includes WebUI changes which may need special expertise labels Mar 20, 2025
@comment-ops-bot
Copy link

I wasn't able to add the following labels: ref

Check that the label exists and is spelt right then try again.

@mawinter69 mawinter69 changed the title [JENKINS-75461] add top button for hetero-list, e.g. "Add build step" [JENKINS-75461] add top button for hetero-list, e.g. "Add Parameter" Mar 20, 2025
@comment-ops-bot
Copy link

I wasn't able to add the following labels: ref

Check that the label exists and is spelt right then try again.

1 similar comment
@comment-ops-bot
Copy link

I wasn't able to add the following labels: ref

Check that the label exists and is spelt right then try again.

@comment-ops-bot comment-ops-bot bot added the rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted label Mar 20, 2025
@krisstern krisstern requested a review from a team March 21, 2025 00:50
Co-authored-by: Tim Jacomb <21194782+timja@users.noreply.github.com>
@timja
Copy link
Member

timja commented Mar 21, 2025

(ATH test failing)

basil pushed a commit to jenkinsci/acceptance-test-harness that referenced this pull request Jun 27, 2025
@github-actions github-actions bot added the unresolved-merge-conflict There is a merge conflict with the target branch. label Aug 7, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2025

Please take a moment and address the merge conflicts of your pull request. Thanks!

@github-actions github-actions bot removed the unresolved-merge-conflict There is a merge conflict with the target branch. label Aug 10, 2025
@github-actions github-actions bot added the unresolved-merge-conflict There is a merge conflict with the target branch. label Nov 11, 2025
@github-actions
Copy link
Contributor

Please take a moment and address the merge conflicts of your pull request. Thanks!

@github-actions github-actions bot removed the unresolved-merge-conflict There is a merge conflict with the target branch. label Nov 17, 2025
@MarkEWaite MarkEWaite mentioned this pull request Dec 8, 2025
8 tasks
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - not manually tested

@timja timja requested a review from a team February 23, 2026 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

developer Changes which impact plugin developers rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted web-ui The PR includes WebUI changes which may need special expertise

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[JENKINS-75461] Please add a "Insert build step" button at the TOP of the build steps

4 participants