Refine User page

[janfaracik]

Small PR to refine the User page(s).

What's changed?

• The side panel now shows the current user, along with their icon/avatar
• User config pages now use an app bar, making the spacing between pages consistent
• 'Account' page now groups the first section under 'General' for consistency with other pages

Before

After

Before

After

Testing done

• Tested with names of various lengths

Proposed changelog entries

• Refine User page.

Proposed changelog category

/label web-ui,rfe

Proposed upgrade guidelines

N/A

Submitter checklist

• The Jira issue, if it exists, is well-described.
• The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
• There is automated testing or an explanation as to why this change has no tests.
• New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
• New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
• New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
• For dependency updates, there are links to external changelogs and, if possible, full differentials.
• For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@jenkinsci/sig-ux

Before the changes are marked as ready-for-merge:

Maintainer checklist

• There are at least two (2) approvals for the pull request and no outstanding requests for change.
• Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
• Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
• Proper changelog labels are set so that the changelog can be generated automatically.
• If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
• If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

[timja]

LGTM

[daniel-beck]

Could you document in design library when to do this and when to use regular titles or when to use app bars? "This exists" isn't enough guidance IMO.

[uhafner]

I wonder why this is required at all? All other Jenkins pages have a different layout: the top level corner of the side panel starts with a link. Only here we have an additional header now. In my opinion either all pages get such a header or no page gets one.

[janfaracik]

Could you document in design library when to do this and when to use regular titles or when to use app bars? "This exists" isn't enough guidance IMO.

Yep. App bar has custom spacing to align with the header which a regular h1 lacks - an app bar should always be used for a page. I'll update Design Library to include that.

I wonder why this is required at all? All other Jenkins pages have a different layout: the top level corner of the side panel starts with a link. Only here we have an additional header now. In my opinion either all pages get such a header or no page gets one.

The intention is for all pages to have an app bar and that's slowly been happening. There's quite a few uses now in core and in plugins where the title is above the side panel, e.g.

[uhafner]

Adding an app bar to all pages is a good idea. This is not what I am concerned about: what totally unclear to me is, if a sub page with app bar should contain an own sidebar navigation or not. Or should it show the global sidebar, or should it hide the sidebar? Some new pages have this sidebar, some not, this is not consistent. Now we have another alternative: a sidebar menu with a custom header? Can't we use the same sidebar concept for all pages?

[janfaracik]

If a sub page with app bar should contain an own sidebar navigation or not.
Or should it show the global sidebar, or should it hide the sidebar?
Some new pages have this sidebar, some not, this is not consistent.
Now we have another alternative: a sidebar menu with a custom header? Can't we use the same sidebar concept for all pages?

The intention is to have the app bar contextual to the page it belongs to, whereas the side panel more belongs to a group of pages (e.g. Design Library has one side panel that its pages inherit, Plugins has one side panel for Updates/Installed/Available, Pipeline Graph View has one side panel for its different stages).

Pages like Dashboard and Jobs will (eventually/hopefully) drop their side panels in favour of an app bar for contextual actions, such as Build/Configure/Delete. In the place of the actual links in the side panel could be tabs/widgets - need to test it out.

There's some guidance on https://weekly.ci.jenkins.io/design-library/layouts/

[daniel-beck]

Based on my previous understanding and

Now we have another alternative: a sidebar menu with a custom header? Can't we use the same sidebar concept for all pages?

it seems both Ulli and I were unaware that these are app-bars as well, just as part of the sidepanel. Although I wonder how this placement would accommodate large labels (e.g., job names), or tasks. A more complete vision, including how to adapt at least most of core, would be nice here before updating individual pages one by one.

[daniel-beck]

Why is there no Jelly tag for this?

[janfaracik]

Good point, added support for icons in App bars.

[github-actions]

Please take a moment and address the merge conflicts of your pull request. Thanks!

[janfaracik]

Found a bug - plugins page is a little messed up. Fixing. Fixed.

[uhafner]

Two pages do not include the new user profile side panel, this should be changed. This is a weird user experience when you click in the sidepanel and suddenly the sidepanel disappears.

[timja]

All looks resolved now.

---

/label ready-for-merge

---

This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!