Skip to content

Refine User page #10807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timja merged 21 commits into from
Aug 3, 2025
Merged

Refine User page #10807

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
0d9f53f
Init
janfaracik Jun 7, 2025
bce3dfa
Update builds.jelly
janfaracik Jun 7, 2025
9ecb97a
Merge branch 'master' into refine-user-page
janfaracik Jul 4, 2025
15cc421
Update _app-bar.scss
janfaracik Jul 4, 2025
acf6aa0
Use app bar
janfaracik Jul 4, 2025
7a4dd4f
Merge branch 'master' into refine-user-page
janfaracik Jul 4, 2025
ed98f9a
Merge branch 'master' into refine-user-page
janfaracik Jul 4, 2025
a5654fa
Merge branch 'master' into refine-user-page
janfaracik Jul 6, 2025
bd0f050
Merge branch 'master' into refine-user-page
janfaracik Jul 8, 2025
25f2689
Merge branch 'master' into refine-user-page
janfaracik Jul 9, 2025
236cf9c
Merge branch 'master' into refine-user-page
krisstern Jul 13, 2025
576a3b4
Merge branch 'master' into refine-user-page
krisstern Jul 15, 2025
70aafb0
Add icon support to app bars
janfaracik Jul 15, 2025
d8fd253
Merge branch 'master' into refine-user-page
janfaracik Jul 16, 2025
9dccc2e
Merge branch 'master' into refine-user-page
janfaracik Jul 17, 2025
6f79e64
Add users name to 'My Views'
janfaracik Jul 17, 2025
a941a8d
Merge branch 'master' into refine-user-page
janfaracik Jul 24, 2025
b07af3c
Fix app bar
janfaracik Jul 24, 2025
31ee3f7
Merge branch 'master' into refine-user-page
janfaracik Jul 25, 2025
a9cf2f1
Merge branch 'master' into refine-user-page
janfaracik Jul 28, 2025
db5ef0e
Merge branch 'master' into refine-user-page
krisstern Aug 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions core/src/main/resources/hudson/model/User/builds.jelly
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,7 @@ THE SOFTWARE.
<st:include page="sidepanel.jelly" />
<l:breadcrumb title="${%Builds}" />
<l:main-panel>
<h1>
${%title(it)}
</h1>
<l:app-bar title="${%Builds}" />

<t:buildListTable builds="${it.builds}"/>
</l:main-panel>
Expand Down
7 changes: 1 addition & 6 deletions core/src/main/resources/hudson/model/User/index.jelly
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,12 +28,7 @@ THE SOFTWARE.
<!-- no need for additional breadcrumb here as we're on an index page already including breadcrumb -->
<l:main-panel>
<div class="jenkins-app-bar">
<div class="jenkins-app-bar__content jenkins-build-caption">
<l:icon src="${h.getUserAvatar(it, '96x96')}" class="jenkins-avatar" />
<h1>
${it.fullName}
</h1>
</div>
<div class="jenkins-app-bar__content" />
<div class="jenkins-app-bar__controls">
<t:editDescriptionButton permission="${app.ADMINISTER}"/>
</div>
Expand Down
10 changes: 9 additions & 1 deletion core/src/main/resources/hudson/model/User/sidepanel.jelly
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,16 @@ THE SOFTWARE.
<j:jelly xmlns:j="jelly:core" xmlns:st="jelly:stapler" xmlns:d="jelly:define" xmlns:l="/lib/layout" xmlns:t="/lib/hudson" xmlns:f="/lib/form" xmlns:i="jelly:fmt">
<l:header />
<l:side-panel>
<div class="jenkins-app-bar">
<div class="jenkins-app-bar__content jenkins-build-caption">
<l:icon src="${h.getUserAvatar(it, '96x96')}" class="jenkins-avatar" />
<h1>
${it.fullName}
</h1>
</div>
</div>
Copy link
Copy Markdown
Member

@daniel-beck daniel-beck Jul 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is there no Jelly tag for this?

Copy link
Copy Markdown
Member Author

@janfaracik janfaracik Jul 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, added support for icons in App bars.

<l:tasks>
<l:task contextMenu="false" href="${rootURL}/${it.url}/" icon="symbol-person-circle" title="${%Status}"/>
<l:task contextMenu="false" href="${rootURL}/${it.url}/" icon="symbol-person" title="${%Profile}"/>
<l:task href="${rootURL}/${it.url}/builds" icon="symbol-build-history" title="${%Builds}"/>
<t:actions actions="${it.propertyActions}"/>
<t:actions actions="${it.transientActions}"/>
Expand Down
8 changes: 3 additions & 5 deletions ...rc/main/resources/hudson/model/userproperty/UserPropertyCategoryAccountAction/index.jelly
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,16 +30,14 @@ THE SOFTWARE.
<l:layout permission="${app.ADMINISTER}" title="${%title}">
<st:include page="sidepanel.jelly" it="${it.targetUser}" />
<l:main-panel>
<f:form method="post" action="configSubmit" name="config" class="jenkins-form">
<h1>
${%title}
</h1>
<l:app-bar title="${%title}" />

<f:form method="post" action="configSubmit" name="config" class="jenkins-form">
<j:set var="thisAction" value="${it}" />
<j:set var="it" value="${thisAction.targetUser}" />
<j:set var="instance" value="${it}"/>

<f:section>
<f:section title="${%General}">
<f:entry title="${%Full name}" description="${%Full name.Description}">
<f:textbox field="fullName" />
</f:entry>
Expand Down
6 changes: 2 additions & 4 deletions ...main/resources/hudson/model/userproperty/UserPropertyCategoryAppearanceAction/index.jelly
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,9 @@ THE SOFTWARE.
<l:layout permission="${app.ADMINISTER}" title="${%title}">
<st:include page="sidepanel.jelly" it="${it.targetUser}" />
<l:main-panel>
<l:app-bar title="${%title}" />

<f:form method="post" action="configSubmit" name="config">
<h1>
${%title}
</h1>

<j:set var="instance" value="${it}"/>
<j:set var="descriptors" value="${it.myCategoryDescriptors}" />
<j:set var="instances" value="${it.targetUser.properties}" />
Expand Down
6 changes: 2 additions & 4 deletions ...in/resources/hudson/model/userproperty/UserPropertyCategoryExperimentalAction/index.jelly
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,9 @@ THE SOFTWARE.
<l:layout permission="${app.ADMINISTER}" title="${%title}">
<st:include page="sidepanel.jelly" it="${it.targetUser}" />
<l:main-panel>
<l:app-bar title="${%title}" />

<f:form method="post" action="configSubmit" name="config">
<h1>
${%title}
</h1>

<j:set var="instance" value="${it}"/>
<j:set var="descriptors" value="${it.myCategoryDescriptors}" />
<j:set var="instances" value="${it.targetUser.properties}" />
Expand Down
6 changes: 2 additions & 4 deletions ...ain/resources/hudson/model/userproperty/UserPropertyCategoryPreferencesAction/index.jelly
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,9 @@ THE SOFTWARE.
<l:layout permission="${app.ADMINISTER}" title="${%title}">
<st:include page="sidepanel.jelly" it="${it.targetUser}" />
<l:main-panel>
<f:form method="post" action="configSubmit" name="config">
<h1>
${%title}
</h1>
<l:app-bar title="${%title}" />

<f:form method="post" action="configSubmit" name="config">
<j:set var="instance" value="${it}"/>
<j:set var="descriptors" value="${it.myCategoryDescriptors}" />
<j:set var="instances" value="${it.targetUser.properties}" />
Expand Down
6 changes: 2 additions & 4 deletions ...c/main/resources/hudson/model/userproperty/UserPropertyCategorySecurityAction/index.jelly
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,9 @@ THE SOFTWARE.
<l:layout permission="${app.ADMINISTER}" title="${%title}">
<st:include page="sidepanel.jelly" it="${it.targetUser}" />
<l:main-panel>
<f:form method="post" action="configSubmit" name="config">
<h1>
${%title}
</h1>
<l:app-bar title="${%title}" />

<f:form method="post" action="configSubmit" name="config">
<j:set var="instance" value="${it}"/>
<j:set var="descriptors" value="${it.myCategoryDescriptors}" />
<j:set var="instances" value="${it.targetUser.properties}" />
Expand Down