Remove trivial tooltips from the help link

[uhafner]

Before this change, the help link showed a trivial tooltip that simply repeated the name of the control. Such tooltips distract the user. Users might even not click the link anymore because they think that the tooltip already shows the actual help message.

Testing done

Removed the test Security2779Test#noXssInHelpLinkPanel as it is superfluous now.

Proposed changelog entries

• human-readable text

Proposed changelog category

/label skip-changelog

Proposed upgrade guidelines

N/A

Submitter checklist

• The Jira issue, if it exists, is well-described.
• The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
• There is automated testing or an explanation as to why this change has no tests.
• New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
• New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
• New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
• For dependency updates, there are links to external changelogs and, if possible, full differentials.
• For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@timja @janfaracik @jenkinsci/sig-ux

Before the changes are marked as ready-for-merge:

Maintainer checklist

• There are at least two (2) approvals for the pull request and no outstanding requests for change.
• Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
• Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
• Proper changelog labels are set so that the changelog can be generated automatically.
• If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
• If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

[janfaracik]

Very much agree with this - I wanted to do this myself.

Thanks!

[timja]

It looks like this was originally the alt text of an img instead of a tooltip so screen readers would have read it out but it wouldn't have been visible directly to users.

787186f

Changed in uhafner@742c99e

Looks like mistakenly by me as some of the help icons had meaningful text which made sense to move there but this one didn't.

Currently this is what voiceover announces on master:

With this branch it just shows a ?

---

I think this should be set as an aria-label, (I've tested locally and it seems right):

Suggested change

	<a href="#" class="jenkins-help-button" helpURL="${rootURL}${attrs.url}">
	<a href="#" class="jenkins-help-button" helpURL="${rootURL}${attrs.url}" aria-label="${altText}">

[uhafner]

That is even better. Then I can leave the variable in place and the only change is the tooltip vs. aria-label.

[timja]

LGTM

[janfaracik]

Thanks, tried and looks good to me.

[timja]

/label ready-for-merge

---

This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

[A1exKH]

LGTM.