Apply staticanalysis.RemoveUnused*

[Pankraz76]

apply:

• https://docs.openrewrite.org/recipes/staticanalysis/removeunusedprivatefields
• https://docs.openrewrite.org/recipes/staticanalysis/removeunusedlocalvariables

See JENKINS-XXXXX.

Testing done

Proposed changelog entries

• human-readable text

Proposed changelog category

/label

Proposed upgrade guidelines

N/A

Submitter checklist

• The Jira issue, if it exists, is well-described.
• The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
• There is automated testing or an explanation as to why this change has no tests.
• New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
• New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
• New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
• For dependency updates, there are links to external changelogs and, if possible, full differentials.
• For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

• There are at least two (2) approvals for the pull request and no outstanding requests for change.
• Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
• Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
• Proper changelog labels are set so that the changelog can be generated automatically.
• If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
• If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

[github-actions]

Missing required label for changelog. Requires at least 1 of: bug, developer, dependencies, internal, localization, major-bug, major-rfe, rfe, regression-fix, removed, skip-changelog. Found: .

You can add the required label by adding a comment with the following text: /label <category>

[daniel-beck]

This is needed to pass the tests in this class. It's not unused, it (intentionally) breaks the serialization, hence the class name and comment.

[daniel-beck]

Introduced in 526c788 to not have warnings during deserialization.

Probably reasonable to remove at this point, but only because of age.

[Pankraz76]

considered obsolete right from the beginning. Perfect example what this project needs. @NotMyFault

• Add rewrite support #10963

Therefore treaded as Technical depth.

use or loose.

You can use silly PMD to fix it all manually or just apply rewrite to get auto fixes. PMD could still benefit as no tool is perfect.

[daniel-beck]

considered obsolete right from the beginning. Perfect example what this project needs.

The behavior of the software changes depending on whether this field is defined or not. If the fields did not exist, administrators are shown warnings from deserialization (in this case of backward-compatibility supporting code), usually indicative of a configuration issue close to data loss. These fields existing prevents that.

So if you think this project needs less backwards compatibility and more administrator confusion, you're exactly right.

[Pankraz76]

These fields existing prevents that.

Did not know that, right. Thanks for explaining to me. Then need simple ignore for this case, as its important.

[Pankraz76]

first need to fix current project setup:

• activate missing check goal of maven-spotless-plugin #10968