Apply staticanalysis.RemoveUnused*

core/src/main/java/hudson/FilePath.java

@@ -1985,8 +1985,6 @@ private static void _chmod(File f, int mask) throws IOException {
         Files.setPosixFilePermissions(fileToPath(f), Util.modeToPermissions(mask));
     }
 
-    private static boolean CHMOD_WARNED = false;
-
     /**
      * Gets the file permission bit mask.
      *

core/src/main/java/hudson/LocalPluginManager.java

@@ -31,7 +31,6 @@
 import java.io.File;
 import java.util.Collection;
 import java.util.Collections;
-import java.util.logging.Logger;
 import jenkins.model.Jenkins;
 import jenkins.util.SystemProperties;
 
@@ -87,6 +86,4 @@ protected Collection<String> loadBundledPlugins() {
             loadDetachedPlugins();
         }
     }
-
-    private static final Logger LOGGER = Logger.getLogger(LocalPluginManager.class.getName());
 }

core/src/main/java/hudson/cli/CancelQuietDownCommand.java

@@ -25,7 +25,6 @@
 package hudson.cli;
 
 import hudson.Extension;
-import java.util.logging.Logger;
 import jenkins.model.Jenkins;
 
 /**
@@ -37,8 +36,6 @@
 @Extension
 public class CancelQuietDownCommand extends CLICommand {
 
-    private static final Logger LOGGER = Logger.getLogger(CancelQuietDownCommand.class.getName());
-
     @Override
     public String getShortDescription() {
         return Messages.CancelQuietDownCommand_ShortDescription();

core/src/main/java/hudson/cli/ClearQueueCommand.java

@@ -25,7 +25,6 @@
 package hudson.cli;
 
 import hudson.Extension;
-import java.util.logging.Logger;
 import jenkins.model.Jenkins;
 
 /**
@@ -37,8 +36,6 @@
 @Extension
 public class ClearQueueCommand extends CLICommand {
 
-    private static final Logger LOGGER = Logger.getLogger(ClearQueueCommand.class.getName());
-
     @Override
     public String getShortDescription() {
         return Messages.ClearQueueCommand_ShortDescription();

core/src/main/java/hudson/cli/ConnectNodeCommand.java

@@ -29,7 +29,6 @@
 import hudson.model.Computer;
 import java.util.HashSet;
 import java.util.List;
-import java.util.logging.Logger;
 import org.kohsuke.args4j.Argument;
 import org.kohsuke.args4j.Option;
 
@@ -48,8 +47,6 @@ public class ConnectNodeCommand extends CLICommand {
     @Option(name = "-f", usage = "Cancel any currently pending connect operation and retry from scratch")
     public boolean force = false;
 
-    private static final Logger LOGGER = Logger.getLogger(ConnectNodeCommand.class.getName());
-
     @Override
     public String getShortDescription() {
         return Messages.ConnectNodeCommand_ShortDescription();

core/src/main/java/hudson/cli/DisconnectNodeCommand.java

@@ -31,7 +31,6 @@
 import hudson.util.EditDistance;
 import java.util.HashSet;
 import java.util.List;
-import java.util.logging.Logger;
 import jenkins.model.Jenkins;
 import org.kohsuke.args4j.Argument;
 import org.kohsuke.args4j.Option;
@@ -49,8 +48,6 @@ public class DisconnectNodeCommand extends CLICommand {
     @Option(name = "-m", usage = "Record the reason about why you are disconnecting this node")
     public String cause;
 
-    private static final Logger LOGGER = Logger.getLogger(DisconnectNodeCommand.class.getName());
-
     @Override
     public String getShortDescription() {
         return Messages.DisconnectNodeCommand_ShortDescription();

core/src/main/java/hudson/cli/QuietDownCommand.java

@@ -25,7 +25,6 @@
 package hudson.cli;
 
 import hudson.Extension;
-import java.util.logging.Logger;
 import jenkins.model.Jenkins;
 import org.kohsuke.args4j.Option;
 
@@ -38,8 +37,6 @@
 @Extension
 public class QuietDownCommand extends CLICommand {
 
-    private static final Logger LOGGER = Logger.getLogger(QuietDownCommand.class.getName());
-
     @Option(name = "-block", usage = "Block until the system really quiets down and no builds are running")
     public boolean block = false;
 

core/src/main/java/hudson/console/ModelHyperlinkNote.java

@@ -10,7 +10,6 @@
 import hudson.model.Node;
 import hudson.model.Run;
 import hudson.model.User;
-import java.util.logging.Logger;
 import jenkins.model.Jenkins;
 import org.jenkinsci.Symbol;
 
@@ -82,6 +81,4 @@ public String getDisplayName() {
     }
 
     private static final long serialVersionUID = 1L;
-
-    private static final Logger LOGGER = Logger.getLogger(ModelHyperlinkNote.class.getName());
 }

core/src/main/java/hudson/model/DownloadService.java

@@ -210,7 +210,6 @@ public static class Downloadable implements ExtensionPoint {
         private final String url;
         private final long interval;
         private volatile long due = 0;
-        private volatile long lastAttempt = Long.MIN_VALUE;
 
         /**
          * Creates a new downloadable.

core/src/main/java/hudson/model/RunParameterDefinition.java

@@ -31,7 +31,6 @@
 import hudson.util.EnumConverter;
 import hudson.util.RunList;
 import java.util.Objects;
-import java.util.logging.Logger;
 import jenkins.model.Jenkins;
 import net.sf.json.JSONObject;
 import org.jenkinsci.Symbol;
@@ -243,6 +242,4 @@ public boolean equals(Object obj) {
             return false;
         return Objects.equals(filter, other.filter);
     }
-
-    private static final Logger LOGGER = Logger.getLogger(RunParameterDefinition.class.getName());
 }

core/src/main/java/hudson/node_monitors/AbstractAsyncNodeMonitorDescriptor.java

@@ -153,7 +153,6 @@ private void error(Computer c, Throwable x) {
      * returns computers that were not monitored as they were either offline or monitor produced {@code null} {@link Callable}.
      */
     protected static final class Result<T> {
-        private static final long serialVersionUID = -7671448355804481216L;
 
         private final @NonNull Map<Computer, T> data;
         private final @NonNull ArrayList<Computer> skipped;

core/src/main/java/hudson/node_monitors/AbstractDiskSpaceMonitor.java

@@ -3,7 +3,6 @@
 import hudson.model.Computer;
 import hudson.node_monitors.DiskSpaceMonitorDescriptor.DiskSpace;
 import java.text.ParseException;
-import java.util.logging.Logger;
 import java.util.regex.Matcher;
 import java.util.regex.Pattern;
 import org.kohsuke.stapler.DataBoundSetter;
@@ -94,7 +93,5 @@
         ((DiskSpaceMonitorDescriptor) getDescriptor()).markNodeOfflineOrOnline(c, size, this);
         return size;
     }
-
-    private static final Logger LOGGER = Logger.getLogger(AbstractDiskSpaceMonitor.class.getName());
     private static final long DEFAULT_THRESHOLD = 1024L * 1024 * 1024;
 }

core/src/main/java/hudson/security/AccessDeniedException2.java

@@ -3,7 +3,6 @@
 import io.jenkins.servlet.http.HttpServletResponseWrapper;
 import java.io.PrintWriter;
 import javax.servlet.http.HttpServletResponse;
-import jenkins.util.SystemProperties;
 import org.acegisecurity.AccessDeniedException;
 import org.acegisecurity.Authentication;
 
@@ -15,9 +14,6 @@
 @Deprecated
 public class AccessDeniedException2 extends AccessDeniedException {
 
-    /** If true, report {@code X-You-Are-In-Group} headers. Disabled due to JENKINS-39402; use {@code /whoAmI} etc. to diagnose permission issues. */
-    private static /* not final */ boolean REPORT_GROUP_HEADERS = SystemProperties.getBoolean(AccessDeniedException2.class.getName() + ".REPORT_GROUP_HEADERS");
-
     /**
      * This object represents the user being authenticated.
      */

core/src/main/java/hudson/util/ChunkedInputStream.java

@@ -34,7 +34,6 @@
 import java.io.IOException;
 import java.io.InputStream;
 import java.nio.charset.StandardCharsets;
-import java.util.logging.Logger;
 
 /**
  * <p>Transparently coalesces chunks of a HTTP stream that uses
@@ -76,9 +75,6 @@ public class ChunkedInputStream extends InputStream {
     /** True if this stream is closed */
     private boolean closed = false;
 
-    /** Log object for this class. */
-    private static final Logger LOGGER = Logger.getLogger(ChunkedInputStream.class.getName());
-
     /**
      * ChunkedInputStream constructor
      *

core/src/main/java/hudson/util/ProcessTree.java

@@ -1311,7 +1311,6 @@ protected OSProcess createProcess(final int pid) throws IOException {
         }
 
         private class SolarisProcess extends UnixProcess {
-            private static final byte PR_MODEL_ILP32 = 1;
             private static final byte PR_MODEL_LP64 = 2;
 
             /*

core/src/main/java/jenkins/cli/SafeRestartCommand.java

@@ -27,7 +27,6 @@
 import hudson.Extension;
 import hudson.cli.CLICommand;
 import hudson.cli.Messages;
-import java.util.logging.Logger;
 import jenkins.model.Jenkins;
 import org.kohsuke.accmod.Restricted;
 import org.kohsuke.accmod.restrictions.NoExternalUse;
@@ -42,7 +41,6 @@
 @Extension
 @Restricted(NoExternalUse.class)
 public class SafeRestartCommand extends CLICommand {
-    private static final Logger LOGGER = Logger.getLogger(SafeRestartCommand.class.getName());
 
     @Option(name = "-message", usage = "Message for safe restart that will be visible to users")
     public String message = null;

core/src/main/java/jenkins/model/JenkinsLocationConfiguration.java

@@ -58,9 +58,6 @@ public class JenkinsLocationConfiguration extends GlobalConfiguration implements
     private String adminAddress;
     private String jenkinsUrl;
 
-    // just to suppress warnings
-    private transient String charset, useSsl;
-
     public static @NonNull JenkinsLocationConfiguration get() {
         return GlobalConfiguration.all().getInstance(JenkinsLocationConfiguration.class);
     }

core/src/main/java/jenkins/model/NodeListener.java

@@ -29,7 +29,6 @@
 import hudson.ExtensionPoint;
 import hudson.model.Node;
 import java.util.List;
-import java.util.logging.Logger;
 import jenkins.util.Listeners;
 import org.kohsuke.accmod.Restricted;
 import org.kohsuke.accmod.restrictions.Beta;
@@ -42,8 +41,6 @@
  */
 public abstract class NodeListener implements ExtensionPoint {
 
-    private static final Logger LOGGER = Logger.getLogger(NodeListener.class.getName());
-
     /**
      * Allows to veto node loading.
      * @param node the node being loaded. Not yet attached to Jenkins.

core/src/main/java/jenkins/security/seed/UserSeedChangeListener.java

@@ -29,16 +29,13 @@
 import hudson.ExtensionPoint;
 import hudson.model.User;
 import java.util.List;
-import java.util.logging.Logger;
-import jenkins.security.SecurityListener;
 import jenkins.util.Listeners;
 
 /**
  * Listener notified when a user was requested to changed their seed
  * @since 2.160 and 2.150.2, but restricted (unavailable to plugins) before 2.406
  */
 public abstract class UserSeedChangeListener implements ExtensionPoint {
-    private static final Logger LOGGER = Logger.getLogger(SecurityListener.class.getName());
 
     /**
      * Called after a seed was changed but before the user is saved.

core/src/main/java/jenkins/slaves/restarter/SlaveRestarter.java

@@ -3,7 +3,6 @@
 import hudson.ExtensionList;
 import hudson.ExtensionPoint;
 import java.io.Serializable;
-import java.util.logging.Logger;
 
 /**
  * Extension point to control how to restart an inbound agent when it loses the connection with the master.
@@ -41,7 +40,5 @@ public static ExtensionList<SlaveRestarter> all() {
         return ExtensionList.lookup(SlaveRestarter.class);
     }
 
-    private static final Logger LOGGER = Logger.getLogger(SlaveRestarter.class.getName());
-
     private static final long serialVersionUID = 1L;
 }

core/src/main/java/jenkins/telemetry/impl/UserLanguages.java

@@ -35,7 +35,6 @@
 import java.util.TreeMap;
 import java.util.concurrent.ConcurrentSkipListMap;
 import java.util.concurrent.atomic.AtomicLong;
-import java.util.logging.Logger;
 import jenkins.telemetry.Telemetry;
 import jenkins.util.HttpServletFilter;
 import net.sf.json.JSONObject;
@@ -47,7 +46,6 @@
 public class UserLanguages extends Telemetry {
 
     private static final Map<String, AtomicLong> requestsByLanguage = new ConcurrentSkipListMap<>();
-    private static Logger LOGGER = Logger.getLogger(UserLanguages.class.getName());
 
     @NonNull
     @Override

core/src/test/java/jenkins/util/MarkFindingOutputStreamTest.java

@@ -15,7 +15,6 @@ class MarkFindingOutputStreamTest {
 
     private String mark = MarkFindingOutputStream.MARK;
     private String markHead = mark.substring(0, 5);
-    private String markTail = mark.substring(5);
 
     private ByteArrayOutputStream baos = new ByteArrayOutputStream();
     private MarkCountingOutputStream m = new MarkCountingOutputStream(baos);

core/src/test/java/jenkins/util/VirtualFileTest.java

@@ -1509,7 +1509,6 @@ private File createInvalidFileSymlink() throws IOException, InterruptedException
     }
 
     private long computeEarlierSystemTime() {
-        long earlierSystemTime = 0L;
         if (Functions.isWindows()) {
             return 0L;
         }

test/src/test/java/hudson/PluginManagerTest.java

@@ -619,7 +619,6 @@ void uploadDependencyResolution() throws Throwable {
 
             // wait for all the download jobs to complete
             boolean done = true;
-            boolean passed = true;
             do {
                 Thread.sleep(100);
                 done = true;

test/src/test/java/hudson/cli/QuietDownCommandTest.java

@@ -393,8 +393,6 @@ void quietDownShouldSuccessWithBlockAndFinishingExecutor() throws Exception {
         final OneShotEvent finish = new OneShotEvent();
         final FreeStyleBuild build = OnlineNodeCommandTest.startBlockingAndFinishingBuild(project, finish);
         assertThat(((FreeStyleProject) j.jenkins.getItem("aProject")).getBuilds(), hasSize(1));
-
-        boolean timeoutOccurred = false;
         final FutureTask exec_task = new FutureTask(() -> {
             assertJenkinsNotInQuietMode();
             final long time_before = System.currentTimeMillis();

test/src/test/java/hudson/model/QueueTest.java

@@ -105,7 +105,6 @@
 import java.util.concurrent.TimeoutException;
 import java.util.concurrent.atomic.AtomicInteger;
 import java.util.function.Function;
-import java.util.logging.Level;
 import java.util.logging.Logger;
 import jenkins.model.BlockedBecauseOfBuildInProgress;
 import jenkins.model.Jenkins;
@@ -125,7 +124,6 @@
 import org.junit.jupiter.api.Test;
 import org.jvnet.hudson.test.Issue;
 import org.jvnet.hudson.test.JenkinsRule;
-import org.jvnet.hudson.test.LogRecorder;
 import org.jvnet.hudson.test.MockAuthorizationStrategy;
 import org.jvnet.hudson.test.MockQueueItemAuthenticator;
 import org.jvnet.hudson.test.SequenceLock;
@@ -143,8 +141,6 @@
 @WithJenkins
 public class QueueTest {
 
-    private final LogRecorder logging = new LogRecorder().record(Queue.class, Level.FINE);
-
     private JenkinsRule r;
 
     @BeforeEach

test/src/test/java/hudson/model/SimpleJobTest.java

@@ -2,12 +2,9 @@
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
 
-import java.util.logging.Level;
-import jenkins.model.lazy.LazyBuildMixIn;
 import org.junit.jupiter.api.BeforeAll;
 import org.junit.jupiter.api.Test;
 import org.jvnet.hudson.test.JenkinsRule;
-import org.jvnet.hudson.test.LogRecorder;
 import org.jvnet.hudson.test.junit.jupiter.WithJenkins;
 
 /**
@@ -16,8 +13,6 @@
 @WithJenkins
 class SimpleJobTest {
 
-    private final LogRecorder logging = new LogRecorder().record(LazyBuildMixIn.class, Level.FINE);
-
     private static JenkinsRule r;
 
     @BeforeAll