Skip to content

Update Winstone and Jetty#10988

Merged
timja merged 1 commit intomasterfrom
renovate/winstone-and-jetty
Oct 10, 2025
Merged

Update Winstone and Jetty#10988
timja merged 1 commit intomasterfrom
renovate/winstone-and-jetty

Conversation

@renovate
Copy link
Contributor

@renovate renovate bot commented Aug 18, 2025

This PR contains the following updates:

Package Change Age Confidence
org.eclipse.jetty.ee9:jetty-ee9-maven-plugin (source) 12.0.25 -> 12.1.2 age confidence
org.jenkins-ci:winstone 8.13.1 -> 8.15 age confidence

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot added dependencies Pull requests that update a dependency file skip-changelog Should not be shown in the changelog labels Aug 18, 2025
Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

@A1exKH A1exKH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@krisstern
Copy link
Member

@A1exKH in jenkinsci/winstone#452 (review):

-0 I guess? I'm not necessarily opposed to upgrading, but past Jetty releases have had a high rate of regression, so part of me would rather wait to upgrade and let others find and report any potential regressions in this .0 release.

This PR is not ready for merge yet.

@A1exKH
Copy link

A1exKH commented Aug 31, 2025

@krisstern I see, thank you for the comment!

@renovate renovate bot force-pushed the renovate/winstone-and-jetty branch from 237a4f9 to 200dba6 Compare September 8, 2025 11:49
@renovate renovate bot changed the title Update dependency org.eclipse.jetty.ee9:jetty-ee9-maven-plugin to v12.1.0 Update dependency org.eclipse.jetty.ee9:jetty-ee9-maven-plugin to v12.1.1 Sep 8, 2025
@renovate renovate bot force-pushed the renovate/winstone-and-jetty branch from 200dba6 to 53e5014 Compare September 17, 2025 10:37
@renovate renovate bot changed the title Update dependency org.eclipse.jetty.ee9:jetty-ee9-maven-plugin to v12.1.1 Update Winstone and Jetty Sep 17, 2025
@renovate renovate bot force-pushed the renovate/winstone-and-jetty branch from 73ad9a5 to f71ec77 Compare September 17, 2025 13:12
@renovate renovate bot changed the title Update Winstone and Jetty Update dependency org.eclipse.jetty.ee9:jetty-ee9-maven-plugin to v12.1.1 Sep 17, 2025
@renovate renovate bot force-pushed the renovate/winstone-and-jetty branch from 7131fbe to b47cd55 Compare September 24, 2025 19:15
@renovate renovate bot force-pushed the renovate/winstone-and-jetty branch from b47cd55 to 5767de9 Compare October 4, 2025 00:25
@renovate renovate bot changed the title Update dependency org.eclipse.jetty.ee9:jetty-ee9-maven-plugin to v12.1.1 Update Winstone and Jetty Oct 4, 2025
@MarkEWaite
Copy link
Contributor

MarkEWaite commented Oct 4, 2025

Tests of this pull request passed in the plugin BOM with:

Currently blocked from upgrading Jenkins test harness with matching Jetty version in plugin BOM by:

I'd really like to know why the test in the http request plugin fails on the transition from Jetty 12.0.28 to 12.1.1 before we merge this to the master branch, but I'm also OK if we accept that risk and identify the root cause of the failure after the merge. The tests pass in this branch and they pass in the plugin BOM with these changes. They only fail when the Jenkins test harness includes Jetty 12.1.1.

@renovate renovate bot force-pushed the renovate/winstone-and-jetty branch from 5767de9 to a7c35b3 Compare October 8, 2025 18:42
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label ready-for-merge


This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Oct 9, 2025
@timja timja mentioned this pull request Oct 9, 2025
14 tasks
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This proposes an inconsistent combination of Jetty and Winstone. The Winstone 8.14 release includes Jetty 12.1.1 but this pull request proposes Jetty 12.1.2.

I think that we want to keep those two in sync, either by releasing a new version of Winstone with Jetty 12.1.2 (my first preference) or changing this pull request to use Jetty 12.1.1.

@renovate renovate bot force-pushed the renovate/winstone-and-jetty branch from a7c35b3 to 8e762d0 Compare October 9, 2025 15:50
@timja
Copy link
Member

timja commented Oct 9, 2025

Addressed

@renovate renovate bot force-pushed the renovate/winstone-and-jetty branch from 8e762d0 to c9cbc15 Compare October 9, 2025 16:22
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@renovate renovate bot force-pushed the renovate/winstone-and-jetty branch from 0260cb9 to a4354d2 Compare October 9, 2025 21:54
@timja timja merged commit 22b0b8d into master Oct 10, 2025
18 checks passed
@timja timja deleted the renovate/winstone-and-jetty branch October 10, 2025 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback skip-changelog Should not be shown in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants