Conversation
|
@A1exKH in jenkinsci/winstone#452 (review):
This PR is not ready for merge yet. |
|
@krisstern I see, thank you for the comment! |
237a4f9 to
200dba6
Compare
200dba6 to
53e5014
Compare
73ad9a5 to
f71ec77
Compare
7131fbe to
b47cd55
Compare
b47cd55 to
5767de9
Compare
|
Tests of this pull request passed in the plugin BOM with: Currently blocked from upgrading Jenkins test harness with matching Jetty version in plugin BOM by: I'd really like to know why the test in the http request plugin fails on the transition from Jetty 12.0.28 to 12.1.1 before we merge this to the master branch, but I'm also OK if we accept that risk and identify the root cause of the failure after the merge. The tests pass in this branch and they pass in the plugin BOM with these changes. They only fail when the Jenkins test harness includes Jetty 12.1.1. |
5767de9 to
a7c35b3
Compare
timja
left a comment
There was a problem hiding this comment.
/label ready-for-merge
This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.
Thanks!
There was a problem hiding this comment.
This proposes an inconsistent combination of Jetty and Winstone. The Winstone 8.14 release includes Jetty 12.1.1 but this pull request proposes Jetty 12.1.2.
I think that we want to keep those two in sync, either by releasing a new version of Winstone with Jetty 12.1.2 (my first preference) or changing this pull request to use Jetty 12.1.1.
a7c35b3 to
8e762d0
Compare
|
Addressed |
8e762d0 to
c9cbc15
Compare
0260cb9 to
a4354d2
Compare
This PR contains the following updates:
12.0.25->12.1.28.13.1->8.15Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR was generated by Mend Renovate. View the repository job log.