Enable Java 25 support#11148
Conversation
The Javadoc comment said: > When executing the resulting Callable, it executes > FileCallable#act(FileCallable) on this FilePath. The FileCallable interface does not have an `act(FileCallable)` method. That absence causes the Javadoc generation to fail on Java 25. There is a `FilePath.act(FileCallable)` method that could be inserted instead, but I'm not confident the comment would then be correct. Testing done: Confirmed that Javadoc generation fails on Java 25 without this change. Confirmed that Javadoc generation passes on Java 25 with this change. (cherry picked from commit 3fdf9c1)
|
Please take a moment and address the merge conflicts of your pull request. Thanks! |
|
Please take a moment and address the merge conflicts of your pull request. Thanks! |
| axes.values().combinations { | ||
| def (platform, jdk) = it | ||
| if (platform == 'windows' && jdk != 17) { | ||
| if (platform == 'windows' && jdk != axes.jdks.last()) { |
There was a problem hiding this comment.
reduces the manual effort to maintain this and decide which one to put
|
Tested via replay, it worked: Java version is out of date on ci.jenkins.io: jenkins-infra/helpdesk#4831 |
|
/label ready-for-merge This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback. Thanks! |
|
Removing ready for merge as we likely need to revert the Jetty upgrade which I believe is needed for this? see #11197 |
Jetty can be downgraded in this pull request to 12.1.1 and Winstone to 8.14. Unfortunately, I can't tell if Jetty 12.1.1 has the issue or not. |
|
It does, any version after the one we were previously on has the issue |
timja
left a comment
There was a problem hiding this comment.
Requires the upcoming Jetty 12.1.3 from what I understand
|
Please take a moment and address the merge conflicts of your pull request. Thanks! |
9cab06d to
6f43077
Compare
|
/label ready-for-merge This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback. Thanks! |
Beginning in March 2029, users will be warned that Java 25 will be reaching its end of support in the Jenkins project. Amends pull request: * jenkinsci#11148 The 2+2+2 Java support plan recommends that we drop support for a Java line after two years so that we're only supporting two Java versions at a time. Refer to the blog post: * https://www.jenkins.io/blog/2023/11/06/introducing-2-2-2-java-support-plan/ Also refer to the Jenkins Enhancement Proposal pull request (incomplete): * jenkinsci/jep#400 Testing done: * None. Relying on the existing behavior that I've seen from the Java 17 administrative monitor. It is now shown to users to warn them that we plan to drop Java 17 support by the end of March 2026
…5925) Warn users of Java 25 end of support September 2029 Beginning in March 2029, users will be warned that Java 25 will be reaching its end of support in the Jenkins project. Amends pull request: * #11148 The 2+2+2 Java support plan recommends that we drop support for a Java line after two years so that we're only supporting two Java versions at a time. Refer to the blog post: * https://www.jenkins.io/blog/2023/11/06/introducing-2-2-2-java-support-plan/ Also refer to the Jenkins Enhancement Proposal pull request (incomplete): * jenkinsci/jep#400 Testing done: * None. Relying on the existing behavior that I've seen from the Java 17 administrative monitor. It is now shown to users to warn them that we plan to drop Java 17 support by the end of March 2026
JENKINS-76170 Support Java 25 in Jenkins.
Allow Jenkins to run with Java 25 without requiring the
enable-future-javaflag.Testing done
mvn package -Pquick-buildand usingwar/target/jenkins.warwith Java 25 to start an instance.Proposed changelog entries
Proposed changelog category
/label major-rfe
Proposed upgrade guidelines
N/A
Submitter checklist
@Restrictedor have@since TODOJavadocs, as appropriate.@Deprecated(since = "TODO")or@Deprecated(forRemoval = true, since = "TODO"), if applicable.evalto ease future introduction of Content Security Policy (CSP) directives (see documentation).Desired reviewers
@mention
Before the changes are marked as
ready-for-merge:Maintainer checklist
upgrade-guide-neededlabel is set and there is a Proposed upgrade guidelines section in the pull request title (see example).lts-candidateto be considered (see query).