Add experimental Manage Jenkins layout#11222
Conversation
This reverts commit db697ec.
|
ATH passed - jenkinsci/acceptance-test-harness#2240 |
timja
left a comment
There was a problem hiding this comment.
Looks great, few minor issues here and I've noted most of my feedback in jenkinsci/sig-ux#10 (comment) for later improvements before this is enabled
| <div class="jenkins-app-bar"> | ||
| <j:set var="header"> | ||
| <l:view> | ||
| <div class="jenkins-app-bar jenkins-!-margin-top-2 jenkins-!-margin-bottom-4"> |
There was a problem hiding this comment.
It doesn't have a slot for the version number.
|
|
||
| <p class="app-about-paragraph">${%blurb}</p> | ||
| <l:settings-subpage header="${header}" | ||
| placeholder="${null}" |
There was a problem hiding this comment.
passing a null placeholder seems wrong why is this needed?
There was a problem hiding this comment.
Otherwise a default app bar appears whilst its loading, its a little jarring seeing it switch to a completely different one.
| <l:app-bar title="${manageJenkinsAction.displayName}" /> | ||
|
|
||
| <l:tasks> | ||
| <l:search-bar placeholder="${%Search}" id="settings-search-bar" /> |
There was a problem hiding this comment.
This doesn't seem to be working for me I get no results
There was a problem hiding this comment.
Rather gross fix - but working now.
That's this PR. Wrong link? |
Fixed the link |
|
/label ready-for-merge This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback. Thanks! |
|
"Reload configuration from disk" has broken text when the experiment is live.
Forms looked cramped, with tons of whitespace to the left and right for no real reason.
Help icons for dropdowns reveals JENKINS-76266 more than usual. Navigating between sections that haven't been adapted, even in core, is jarring. In particular, it's unclear how the plugin manager would be adapted to work with this UI. None of this is blocking, I think, and probably fine for an experiment. |
There's a follow up ready for this, sub-menus under the Plugins link in the side-panel but Jan didn't want to add too much in this PR as that needs more machinery to add to make it work. |
| @Override | ||
| public String getUrlName() { | ||
| return "administrativeMonitor/OldData/"; | ||
| return "administrativeMonitor/OldData/manage"; |
There was a problem hiding this comment.
Do we know why manage.jelly isn't just index.jelly? Seems unnecessary.
There was a problem hiding this comment.
I agree - happy to experiment with renaming it to index.jelly in a follow up.
manage.jelly was added in 07f0405#diff-83d7a9405bfbe87e69167b2e0bc36db7070c3de282390b72f90eac9db2adc0f8R19-R238 not clear why they didn't just use index.
|
Caused #23856. |





Requires jenkinsci/maven-hpi-plugin#803- ReleasedThis PR adds an experimental Manage Jenkins redesign - the idea is to standardise and modernise each page, improving the design, consistency, and performance.
What's changed?
settings-subpage- reusable frame for Manage Jenkins pagesWhat needs doing in future PRs?
Testing done
Proposed changelog entries
Proposed changelog category
/label web-ui,rfe
Proposed upgrade guidelines
N/A
Submitter checklist
@Restrictedor have@since TODOJavadocs, as appropriate.@Deprecated(since = "TODO")or@Deprecated(forRemoval = true, since = "TODO"), if applicable.evalto ease future introduction of Content Security Policy (CSP) directives (see documentation).Desired reviewers
@jenkinsci/sig-ux
Before the changes are marked as
ready-for-merge:Maintainer checklist
upgrade-guide-neededlabel is set and there is a Proposed upgrade guidelines section in the pull request title (see example).lts-candidateto be considered (see query).