Merged
Conversation
|
Yay, your first pull request towards Jenkins core was created successfully! Thank you so much! |
MarkEWaite
requested changes
Jan 6, 2026
Contributor
MarkEWaite
left a comment
MarkEWaite
left a comment
There was a problem hiding this comment.
Requesting changes for unexpected update of NodeJS version and unexpected backport of the Java 17 removal.
Member
|
Please drop the commit 5afa4b4 and update the PR description as the tool generates. |
51 tasks
shalinisudarsan
force-pushed
the
backport-2.541.1
branch
from
4fef347 to
d220ed4
Compare
* Add telemetry for Content Security Policy * Add license header * Add header length --------- Co-authored-by: Daniel Beck <daniel-beck@users.noreply.github.com> (cherry picked from commit 88fdfa9)
Co-authored-by: Daniel Beck <daniel-beck@users.noreply.github.com> (cherry picked from commit 67db131)
… response header can be >30KB (jenkinsci#25901) Co-authored-by: Daniel Beck <daniel-beck@users.noreply.github.com> (cherry picked from commit 52e050e)
…enkinsci#25968) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> (cherry picked from commit c54a0b3)
Partially reverts 331c768. In jenkinsci#8960 the `out` id was added to `pre.console-output`'s "otherwise" case in `console.jelly`. In 331c768, the `out` id was removed from `otherwise` when console output was moved from `console.jelly` to `console-log.jelly`. This may have broken the "Copy" button in some instances. When clicked, the copy button will copy the inner text of a container with the id referred to by the `ref` attribute of the copy button. The copy button's ref attribute is `out`. Wikimedia's Jenkins has no element with the `out` id on the console page, which leads to copying `null` to the clipboard. This was filed as https://phabricator.wikimedia.org/T410633. Co-authored-by: Mark Waite <mark.earl.waite@gmail.com> (cherry picked from commit abecec2)
…kinsci#26004) * Use absolute URL in Cloud sidepanel The urls in the sidepanel of a cloud are relative. When an action is added to the cloud these urls lead to a 404 as the action has a different path. fixes jenkinsci#26002 * Update core/src/main/resources/hudson/slaves/Cloud/sidepanel.jelly Co-authored-by: Alexander Brandes <brandes.alexander@web.de> --------- Co-authored-by: Alexander Brandes <brandes.alexander@web.de> (cherry picked from commit ffc46de)
Reinstantiate telemetry for Java properties Signed-off-by: Alexander Brandes <mc.cache@web.de> (cherry picked from commit 2e58b23)
shalinisudarsan
force-pushed
the
backport-2.541.1
branch
from
d220ed4 to
a12e1e7
Compare
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> (cherry picked from commit eea060c)
14 tasks
MarkEWaite
approved these changes
Jan 9, 2026
Contributor
MarkEWaite
left a comment
MarkEWaite
left a comment
There was a problem hiding this comment.
I checked on multiple Windows machines in my test environment and confirmed that this is ready to merge. Yes, even my fastest Windows machines in my test environment still need 3 hours to complete the tests, but they ran to completion. No surprises. Ready to merge.
Member
|
Thanks @MarkEWaite! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/jenkinsci/jenkins/issues?q=state%3Aclosed%20label%3A2.541.1-fixed
Proposed changelog category
/label
Proposed upgrade guidelines
N/A
Desired reviewers
@mention
Before the changes are marked as
ready-for-merge:Maintainer checklist
upgrade-guide-neededlabel is set and there is a Proposed upgrade guidelines section in the pull request title (see example).lts-candidateto be considered.