Removed the dismiss button and added X by Rahul-2006 · Pull Request #26076 · jenkinsci/jenkins

Rahul-2006 · 2026-01-06T17:40:46Z

Testing done

Previously: This uses Dismiss button:

Now:
Since we have replaced the Dismiss button with X this is the after changes UI:

Tested the change of deleting physically via UI:

Verifying the disabled or not via scripting too!

So a clear view of the changed lines in the code reflected accurately in the UI as tested both via UI and scripting

Screenshots (UI changes only)

These are the same as attached above, added both the before and after states.. right above, not adding them again to reduce the redundancy!!

Proposed changelog category

/label rfe,web-ui

Proposed upgrade guidelines

N/A

Difference between other commits and this one:

I have not just updated a single repeatable file instead, worked on the entire admin monitors message.jelly files which are the main reason to get the Dismiss button
Others solutions might be working on the css which can potentially lead to changes in other components ui behaviour
I have also tested the working of the (X) button via scripting which ensures that the button is triggered to the correct cause
The button after clicked creates a /act post request which returns 302 (as expected).

Submitter checklist

The issue, if it exists, is well-described.
The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
There is automated testing or an explanation as to why this change has no tests.
New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
UI changes do not introduce regressions when enforcing the current default rules of Content Security Policy Plugin. In particular, new or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
For dependency updates, there are links to external changelogs and, if possible, full differentials.
For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@mention
Before the changes are marked as ready-for-merge:

Maintainer checklist

There are at least two (2) approvals for the pull request and no outstanding requests for change.
Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
Proper changelog labels are set so that the changelog can be generated automatically.
If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
If it would make sense to backport the change to LTS, be a Bug or Improvement, and either the issue or pull request must be labeled as lts-candidate to be considered.

daniel-beck

The lines I commented on need explanation or fixing, they seem wrong.

daniel-beck · 2026-01-06T17:44:10Z

core/src/main/resources/hudson/diagnosis/HudsonHomeDiskUsageMonitor/message.jelly

  <form method="post" action="${rootURL}/${it.url}/act" name="${it.id}">
    <f:submit name="yes" value="${%Tell me more}"/>
-    <f:submit name="no" value="${%Dismiss}"/>
+      <l:isAdmin>


daniel-beck · 2026-01-06T17:44:13Z

core/src/main/resources/hudson/diagnosis/OldDataMonitor/message.jelly

    <form method="post" action="${rootURL}/${it.url}/act" name="${it.id}">
      <f:submit name="yes" value="${%Manage}"/>
-      <f:submit name="no" value="${%Dismiss}"/>
+      <l:isAdmin>


daniel-beck · 2026-01-06T17:44:42Z

core/src/main/resources/hudson/node_monitors/MonitorMarkedNodeOffline/message.jelly

-      <f:submit value="${%Dismiss}"/>
+      <button type="submit"
+              class="jenkins-button jenkins-button--tertiary"
+              name="no"


daniel-beck · 2026-01-06T17:45:11Z

core/src/main/resources/jenkins/diagnostics/RootUrlNotSetMonitor/message.jelly

-        <f:submit value="${%Dismiss}"/>
+        <button type="submit"
+                class="jenkins-button jenkins-button--tertiary"
+                name="no"


daniel-beck · 2026-01-06T17:45:34Z

core/src/main/resources/jenkins/security/csp/impl/CspRecommendation/message.jelly

        <form method="post" action="${rootURL}/${it.url}/act" name="${it.id}">
            <f:submit name="more" value="${%Learn more}"/>
-            <f:submit name="dismiss" primary="false" value="${%Dismiss}"/>
+        <l:isAdmin>


daniel-beck · 2026-01-06T17:45:38Z

core/src/main/resources/jenkins/security/csrf/CSRFAdministrativeMonitor/message.jelly

    <div class="jenkins-alert jenkins-alert-warning">
        <form method="post" action="${rootURL}/${it.url}/disable">
-            <f:submit value="${%Dismiss}"/>
+            <l:isAdmin>


daniel-beck · 2026-01-06T17:45:44Z

core/src/main/resources/jenkins/security/csrf/CSRFAdministrativeMonitor/message.jelly

+                <button type="submit"
+                        class="jenkins-button jenkins-button--tertiary"
+                        value="${%Dismiss}"
+                        name="no">


daniel-beck · 2026-01-06T17:47:06Z

core/src/main/resources/jenkins/security/csp/impl/CspRecommendation/message.jelly

+        <l:isAdmin>
+            <button type="submit"
+                    class="jenkins-button jenkins-button--tertiary"
+                    value="${%Dismiss}"
+                    name="dismiss">
+              <l:icon src="symbol-close"/>
+            </button>
+        </l:isAdmin>


Formatting inconsistent with the rest of the file.

Rahul-2006 · 2026-01-07T16:24:36Z

@daniel-beck Hey, Can you please elaborate your Why!? Like i haven't understood What's behind that Why?

daniel-beck · 2026-01-07T17:35:02Z

@daniel-beck Hey, Can you please elaborate your Why!? Like i haven't understood What's behind that Why?

Every line I commented on lacks justification and seems unrelated to this PR's goal.

Rahul-2006 · 2026-01-08T17:24:40Z

So as far as I understood the issue and tested the way towards the issue, I find it the issue is getting solved by the above fixes...
And they aren't creating any new bugs, i followed the code structure too!

Removed the dismiss button and added X

0a17058

comment-ops-bot bot added rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted web-ui The PR includes WebUI changes which may need special expertise labels Jan 6, 2026

daniel-beck reviewed Jan 6, 2026

View reviewed changes

Merge branch 'master' into uifix

31b2dfa

Rahul-2006 requested a review from daniel-beck January 15, 2026 12:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Removed the dismiss button and added X#26076

Removed the dismiss button and added X#26076
Rahul-2006 wants to merge 2 commits intojenkinsci:masterfrom
Rahul-2006:uifix

Rahul-2006 commented Jan 6, 2026

Uh oh!

daniel-beck left a comment

Uh oh!

daniel-beck Jan 6, 2026

Uh oh!

daniel-beck Jan 6, 2026

Uh oh!

daniel-beck Jan 6, 2026

Uh oh!

daniel-beck Jan 6, 2026

Uh oh!

daniel-beck Jan 6, 2026

Uh oh!

daniel-beck Jan 6, 2026

Uh oh!

daniel-beck Jan 6, 2026

Uh oh!

daniel-beck Jan 6, 2026

Uh oh!

Rahul-2006 commented Jan 7, 2026

Uh oh!

daniel-beck commented Jan 7, 2026

Uh oh!

Rahul-2006 commented Jan 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

Rahul-2006 commented Jan 6, 2026

Testing done

Screenshots (UI changes only)

Proposed changelog category

Proposed upgrade guidelines

Difference between other commits and this one:

Submitter checklist

Desired reviewers

Maintainer checklist

Uh oh!

daniel-beck left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Rahul-2006 commented Jan 7, 2026

Uh oh!

daniel-beck commented Jan 7, 2026

Uh oh!

Rahul-2006 commented Jan 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants