Skip to content

Removed the dismiss button and added X #26076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Rahul-2006 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Removed the dismiss button and added X #26076

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0a17058
Removed the dismiss button and added X
Rahul-2006 Jan 6, 2026
31b2dfa
Merge branch 'master' into uifix
Rahul-2006 Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion core/src/main/resources/hudson/diagnosis/HudsonHomeDiskUsageMonitor/message.jelly
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,15 @@ THE SOFTWARE.
<div class="jenkins-alert jenkins-alert-warning">
<form method="post" action="${rootURL}/${it.url}/act" name="${it.id}">
<f:submit name="yes" value="${%Tell me more}"/>
<f:submit name="no" value="${%Dismiss}"/>
<l:isAdmin>
Copy link
Member

@daniel-beck daniel-beck Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

<button type="submit"
class="jenkins-button jenkins-button--tertiary"
name="no"
value="${%Dismiss}"
title="${%Dismiss}">
<l:icon src="symbol-close"/>
</button>
</l:isAdmin>
</form>
${%blurb(app.rootDir)}
</div>
Expand Down
10 changes: 9 additions & 1 deletion core/src/main/resources/hudson/diagnosis/OldDataMonitor/message.jelly
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,15 @@ THE SOFTWARE.
<div class="jenkins-alert jenkins-alert-warning">
<form method="post" action="${rootURL}/${it.url}/act" name="${it.id}">
<f:submit name="yes" value="${%Manage}"/>
<f:submit name="no" value="${%Dismiss}"/>
<l:isAdmin>
Copy link
Member

@daniel-beck daniel-beck Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

<button type="submit"
class="jenkins-button jenkins-button--tertiary"
name="no"
value="${%Dismiss}"
title="${%Dismiss}">
<l:icon src="symbol-close"/>
</button>
</l:isAdmin>
</form>
${%You have data stored in an older format and/or unreadable data.}
</div>
Expand Down
7 changes: 6 additions & 1 deletion core/src/main/resources/hudson/diagnosis/ReverseProxySetupMonitor/message.jelly
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,12 @@ THE SOFTWARE.
<form method="post" action="${rootURL}/${it.url}/act" name="${it.id}">
<f:submit name="yes" value="${%More Info}"/>
<l:isAdmin>
<f:submit name="no" value="${%Dismiss}"/>
<button type="submit"
class="jenkins-button jenkins-button--tertiary"
value="${%Dismiss}"
name="no">
<l:icon src="symbol-close"/>
</button>
</l:isAdmin>
</form>
<div>${%blurb}</div>
Expand Down
7 changes: 6 additions & 1 deletion core/src/main/resources/hudson/diagnosis/TooManyJobsButNoView/message.jelly
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,12 @@ THE SOFTWARE.
<l:isAdmin>
<form method="post" action="${rootURL}/${it.url}/act" name="${it.id}">
<f:submit name="yes" value="${%Create a view now}"/>
<f:submit name="no" value="${%Dismiss}"/>
<button type="submit"
class="jenkins-button jenkins-button--tertiary"
value="${%Dismiss}"
name="no">
<l:icon src="symbol-close"/>
</button>
</form>
</l:isAdmin>
${%blurb}
Expand Down
8 changes: 7 additions & 1 deletion core/src/main/resources/hudson/node_monitors/MonitorMarkedNodeOffline/message.jelly
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,13 @@ THE SOFTWARE.
<j:jelly xmlns:j="jelly:core" xmlns:st="jelly:stapler" xmlns:d="jelly:define" xmlns:l="/lib/layout" xmlns:t="/lib/hudson" xmlns:f="/lib/form">
<div class="jenkins-alert jenkins-alert-warning">
<form method="post" action="${rootURL}/${it.url}/disable">
<f:submit value="${%Dismiss}"/>
<button type="submit"
class="jenkins-button jenkins-button--tertiary"
name="no"
Copy link
Member

@daniel-beck daniel-beck Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

value="${%Dismiss}"
title="${%Dismiss}">
<l:icon src="symbol-close"/>
</button>
</form>
${%blurb(rootURL)}
</div>
Expand Down
9 changes: 7 additions & 2 deletions core/src/main/resources/jenkins/diagnostics/ControllerExecutorsAgents/message.jelly
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,13 @@ THE SOFTWARE.
<div class="jenkins-alert jenkins-alert-warning">
<form method="post" action="${rootURL}/${it.url}/act" name="${it.id}">
<f:submit name="yes" value="${%Manage}"/>
<f:submit name="no" value="${%Dismiss}"/>
</form>
<button type="submit"
class="jenkins-button jenkins-button--tertiary"
value="${%Dismiss}"
name="no">
<l:icon src="symbol-close"/>
</button>
</form>

${%ExecutorsWarning}
</div>
Expand Down
7 changes: 6 additions & 1 deletion core/src/main/resources/jenkins/diagnostics/ControllerExecutorsNoAgents/message.jelly
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,12 @@ THE SOFTWARE.
<form method="post" action="${rootURL}/${it.url}/act" name="${it.id}">
<f:submit name="agent" value="${%Set up agent}"/>
<f:submit name="cloud" value="${%Set up cloud}"/>
<f:submit name="no" value="${%Dismiss}"/>
<button type="submit"
class="jenkins-button jenkins-button--tertiary"
value="${%Dismiss}"
name="no">
<l:icon src="symbol-close"/>
</button>
</form>
${%ExecutorsWarning}
</div>
Expand Down
8 changes: 7 additions & 1 deletion core/src/main/resources/jenkins/diagnostics/RootUrlNotSetMonitor/message.jelly
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,13 @@ THE SOFTWARE.
<div class="jenkins-alert jenkins-alert-warning">
<l:isAdmin>
<form method="post" action="${rootURL}/${it.url}/disable">
<f:submit value="${%Dismiss}"/>
<button type="submit"
class="jenkins-button jenkins-button--tertiary"
name="no"
Copy link
Member

@daniel-beck daniel-beck Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

value="${%Dismiss}"
title="${%Dismiss}">
<l:icon src="symbol-close"/>
</button>
</form>
</l:isAdmin>
<j:set var="actionAnchor">
Expand Down
10 changes: 8 additions & 2 deletions core/src/main/resources/jenkins/diagnostics/SecurityIsOffMonitor/message.jelly
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,14 @@ THE SOFTWARE.
<div class="jenkins-alert jenkins-alert-warning">
<form method="post" action="${rootURL}/${it.url}/act" name="${it.id}">
<f:submit name="yes" value="${%Setup Security}"/>
<f:submit name="no" value="${%Dismiss}"/>
</form>
<button type="submit"
class="jenkins-button jenkins-button--tertiary"
name="no"
value="${%Dismiss}"
title="${%Dismiss}">
<l:icon src="symbol-close"/>
</button>
</form>
${%blurb}
</div>
</j:jelly>
8 changes: 7 additions & 1 deletion core/src/main/resources/jenkins/model/BuiltInNodeMigration/message.jelly
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,13 @@
<div class="jenkins-alert jenkins-alert-warning">
<form method="post" action="${rootURL}/${it.url}/act" name="${it.id}">
<f:submit name="yes" value="${%Apply Migration}"/>
<f:submit name="no" value="${%Dismiss}"/>
<button type="submit"
class="jenkins-button jenkins-button--tertiary"
name="no"
value="${%Dismiss}"
title="${%Dismiss}">
<l:icon src="symbol-close"/>
</button>
</form>
${%blurb}
</div>
Expand Down
11 changes: 9 additions & 2 deletions core/src/main/resources/jenkins/security/csp/impl/CspRecommendation/message.jelly
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,18 @@ OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
THE SOFTWARE.
-->
<?jelly escape-by-default='true'?>
<j:jelly xmlns:j="jelly:core" xmlns:f="/lib/form">
<j:jelly xmlns:j="jelly:core" xmlns:f="/lib/form" xmlns:l="/lib/layout">
<div class="jenkins-alert jenkins-alert-info">
<form method="post" action="${rootURL}/${it.url}/act" name="${it.id}">
<f:submit name="more" value="${%Learn more}"/>
<f:submit name="dismiss" primary="false" value="${%Dismiss}"/>
<l:isAdmin>
Copy link
Member

@daniel-beck daniel-beck Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

<button type="submit"
class="jenkins-button jenkins-button--tertiary"
value="${%Dismiss}"
name="dismiss">
<l:icon src="symbol-close"/>
</button>
</l:isAdmin>
Comment on lines +29 to +36
Copy link
Member

@daniel-beck daniel-beck Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formatting inconsistent with the rest of the file.

</form>
${%blurb}
</div>
Expand Down
9 changes: 8 additions & 1 deletion core/src/main/resources/jenkins/security/csrf/CSRFAdministrativeMonitor/message.jelly
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,14 @@ THE SOFTWARE.
<j:jelly xmlns:j="jelly:core" xmlns:f="/lib/form">
<div class="jenkins-alert jenkins-alert-warning">
<form method="post" action="${rootURL}/${it.url}/disable">
<f:submit value="${%Dismiss}"/>
<l:isAdmin>
Copy link
Member

@daniel-beck daniel-beck Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

<button type="submit"
class="jenkins-button jenkins-button--tertiary"
value="${%Dismiss}"
name="no">
Copy link
Member

@daniel-beck daniel-beck Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

<l:icon src="symbol-close"/>
</button>
</l:isAdmin>
</form>
<j:set var="referenceAnchor">
<a href="https://www.jenkins.io/redirect/csrf-protection" rel="noopener noreferrer" target="_blank">${%referenceUrlContent}</a>
Expand Down
Loading