Skip to content

Encode log recorder name when redirecting #26331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MarkEWaite merged 3 commits into from
Feb 20, 2026
Merged

Encode log recorder name when redirecting #26331

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1b26016
[JENKINS-26318] Encode log recorder redirect name
Flamki Feb 18, 2026
ccc68e1
[JENKINS-26318] Fix import order in test
Flamki Feb 19, 2026
5084be4
Merge branch 'master' into fix-log-recorder-non-ascii-26318
Flamki Feb 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/src/main/java/hudson/logging/LogRecorderManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ public HttpResponse doNewLogRecorder(@QueryParameter String name) {
recorders.add(new LogRecorder(name));

// redirect to the config screen
return new HttpRedirect(name + "/configure");
return new HttpRedirect(Util.rawEncode(name) + "/configure");
}

@Restricted(NoExternalUse.class)
Expand Down
14 changes: 14 additions & 0 deletions test/src/test/java/hudson/logging/LogRecorderManagerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@
import hudson.model.Saveable;
import hudson.model.listeners.SaveableListener;
import hudson.remoting.VirtualChannel;
import hudson.Util;
import hudson.util.FormValidation;
import java.io.IOException;
import java.net.HttpURLConnection;
Expand Down Expand Up @@ -130,6 +131,19 @@ void logRecorderCheckName() {
assertEquals(FormValidation.ok(), testRecorder.doCheckName("a", Level.OFF.getName()));
}

@Test
void createLogRecorderWithNonAsciiName() throws Exception {
String name = "Journal d’accès";

HtmlPage page = j.createWebClient().goTo("log/new");
HtmlForm form = page.getFormByName("configSubmit");
form.getInputByName("name").setValueAttribute(name);
j.submit(form);

assertNotNull(j.jenkins.getLog().getLogRecorder(name));
j.createWebClient().goTo("log/" + Util.rawEncode(name) + "/configure");
}

@Issue({"JENKINS-18274", "JENKINS-63458"})
@Test
void loggingOnSlaves() throws Exception {
Expand Down