Check for null result of getFixVersion

[davedevretro]

Issue #658

Check for null result of getFixVersions as per example on atlassian site:
https://developer.atlassian.com/server/jira/platform/creating-workflow-extensions/#step-2.-edit-the-code

Tested on my local Jenkins instance.
🚨 Please review the guidelines for contributing to this repository.

• Make sure you are requesting to pull a topic/feature/bugfix branch (right side) and not your master branch!
• Ensure that the pull request title represents the desired changelog entry
• Please describe what you did
• Link to relevant issues in GitHub
• Link to relevant pull requests, esp. upstream and downstream changes
• Ensure you have provided tests - that demonstrates feature works or fixes the issue

[rantoniuk]

Thanks for the contribution! I see you have checked Ensure you have provided tests but I don't see any test file modified, did you miss adding it to the PR?

[davedevretro]

Sorry I thought this meant that I was confirming it was tested - unticked now.

[rantoniuk]

Build fails because of format check failure.
You need to run mvn spotless:apply after all changes, before committing changes

[rantoniuk]

How about using ListUtils.emptyIfNull() instead of adding the if clause?

[rantoniuk]

Scratch that, we're stuck on version 3 for now, that doesn't have this.

[rantoniuk]

Found another way using Java8 Optional:

for (Version currentVersion : Optional.ofNullable(issue.getFixVersions()).orElse(Collections.emptyList())) {

[davedevretro]

Is it starting to break readability for minimal gain at this point?

[rantoniuk]

I think it looks cleaner than adding another nested if statement, especially when there is no else (maybe we should consider adding LOGGING.fine()) , but it's fine if you want to leave it as it is.

Would you be able to add a test for this? I think this should be pretty easy by mocking the Null response object.

[davedevretro]

Couldn't work out how to get a unit test to work for this case - sorry.. :/

[davedevretro]

updated formatting