Skip to content

Explicitly declare dependencies#423

Merged
damianszczepanik merged 2 commits intojenkinsci:masterfrom
MarkEWaite:explicitly-declare-dependencies
Jan 10, 2026
Merged

Explicitly declare dependencies#423
damianszczepanik merged 2 commits intojenkinsci:masterfrom
MarkEWaite:explicitly-declare-dependencies

Conversation

@MarkEWaite
Copy link
Contributor

Explicitly declare dependencies

Reduce the risk that new dependencies will be injected accidentally from a dependency update.

Rely on commons-beanutils that is provided by Jenkins core rather than including a copy of commons-beanutils in the hpi file of the plugin.

The developer documentation provides more details.

Originally added to Maven hpi plugin in pull request:

Replace the lone use of commons collection with standard Java so that commons-collection is not included in the hpi file.

There is not enough benefit from this one call to justify a dependency on the commons collection library.

Testing done

  • Confirmed that automated tests pass

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes

There is not enough benefit from this one call to justify a dependency
on the commons collection library.
Reduce the risk that new dependencies will be injected accidentally from
a dependency update.

Rely on commons-beanutils that is provided by Jenkins core rather than
including a copy of commons-beanutils in the hpi file of the plugin.

The developer documentation provides more details at
https://www.jenkins.io/doc/developer/plugin-development/dependencies-and-class-loading/#build-time-validation-of-bundled-artifacts

Originally added to Maven hpi plugin in pull request:

* jenkinsci/maven-hpi-plugin#771

Testing done

* Confirmed that automated tests pass
@damianszczepanik damianszczepanik merged commit 049bccf into jenkinsci:master Jan 10, 2026
22 checks passed
@MarkEWaite MarkEWaite deleted the explicitly-declare-dependencies branch January 13, 2026 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants