Skip to content

Explicitly declare dependencies #423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
damianszczepanik merged 2 commits into from
Jan 10, 2026
Merged

Explicitly declare dependencies #423

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9c0e217
Replace the lone use of commons collection with standard Java
MarkEWaite Jan 10, 2026
5267009
Explicitly declare dependencies
MarkEWaite Jan 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,9 @@
<jenkins.version>${jenkins.baseline}.3</jenkins.version>

<gitHubRepo>jenkinsci/office-365-connector-plugin</gitHubRepo>
<ban-junit4-imports.skip>false</ban-junit4-imports.skip>
<hpi.bundledArtifacts>commons-digester,commons-validator</hpi.bundledArtifacts>
<hpi.strictBundledArtifacts>true</hpi.strictBundledArtifacts>
<ban-junit4-imports.skip>false</ban-junit4-imports.skip>
</properties>

<dependencyManagement>
Expand All @@ -57,6 +59,11 @@
<scope>test</scope>
</dependency>

<dependency>
<groupId>commons-beanutils</groupId>
<artifactId>commons-beanutils</artifactId>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>io.jenkins.plugins</groupId>
<artifactId>apache-httpcomponents-client-5-api</artifactId>
Expand Down
3 changes: 1 addition & 2 deletions src/main/java/jenkins/plugins/office365connector/FactsBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@
import jenkins.plugins.office365connector.model.Fact;
import jenkins.plugins.office365connector.model.FactDefinition;
import jenkins.scm.RunWithSCM;
import org.apache.commons.collections.CollectionUtils;
import org.apache.commons.lang.StringUtils;
import org.jenkinsci.plugins.tokenmacro.MacroEvaluationException;
import org.jenkinsci.plugins.tokenmacro.TokenMacro;
Expand Down Expand Up @@ -120,7 +119,7 @@
}

public void addUserFacts(List<FactDefinition> factDefinitions) {
if (CollectionUtils.isNotEmpty(factDefinitions)) {
if (factDefinitions != null && !factDefinitions.isEmpty()) {

Check warning on line 122 in src/main/java/jenkins/plugins/office365connector/FactsBuilder.java

View check run for this annotation

ci.jenkins.io / Code Coverage

Partially covered line 

Line 122 is only partially covered, one branch is missing
for (FactDefinition factDefinition : factDefinitions) {
addFact(factDefinition.getName(), evaluateMacro(factDefinition.getTemplate()));
}
Expand Down
Loading