Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request applies automated code formatting fixes using the "Sportless" tool to improve code consistency and style across the codebase. The changes address formatting issues in test files and the POM configuration without modifying any functional behavior.
Changes:
- Fixed string concatenation indentation and formatting in test code
- Reordered imports to follow Java conventions (static imports first)
- Improved method declaration formatting and line breaking
- Corrected XML indentation and dependency ordering in POM
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/test/java/io/jenkins/plugins/opentelemetry/job/step/WithNewSpanStepTest.java |
Fixed indentation of string concatenation operator |
src/test/java/io/jenkins/plugins/opentelemetry/JenkinsOtelPluginMBPIntegrationTest.java |
Consolidated text block declaration onto a single line |
src/test/java/io/jenkins/plugins/opentelemetry/JenkinsOpenTelemetryPluginConfigurationIntegrationTest.java |
Reordered static imports, improved method formatting and line breaking, removed trailing blank line |
pom.xml |
Fixed property indentation and reordered commons-lang3-api dependency for better organization |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
v1v
approved these changes
Jan 19, 2026
alecharp
reviewed
Feb 2, 2026
Comment on lines
+198
to
+201
| <dependency> | ||
| <groupId>io.jenkins.plugins</groupId> | ||
| <artifactId>commons-lang3-api</artifactId> | ||
| </dependency> |
Member
There was a problem hiding this comment.
to answer #1213 (comment):
This was not moved out of dependency management. Just reordered within the <dependencies/> tag. Removed line here (156-159) were not in dependency management.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes minor dependency and formatting changes, as well as some small improvements to test code readability. No functionality or logic has been changed.
Dependency Management:
commons-lang3-apidependency withinpom.xmlto a different location in the dependencies list for better organization. [1] [2]Test Code Formatting:
JenkinsOpenTelemetryPluginConfigurationIntegrationTest.javaby grouping static imports at the top. [1] [2]JenkinsOtelPluginMBPIntegrationTest.javaby removing unnecessary line breaks.