Skip to content

fix: apply Sportless#1217

Merged
kuisathaverat merged 2 commits intojenkinsci:mainfrom
kuisathaverat:fix/splotless
Jan 19, 2026
Merged

fix: apply Sportless#1217
kuisathaverat merged 2 commits intojenkinsci:mainfrom
kuisathaverat:fix/splotless

Conversation

@kuisathaverat
Copy link
Contributor

@kuisathaverat kuisathaverat commented Jan 18, 2026

This pull request includes minor dependency and formatting changes, as well as some small improvements to test code readability. No functionality or logic has been changed.

  • Dependency Management:

    • Moved the commons-lang3-api dependency within pom.xml to a different location in the dependencies list for better organization. [1] [2]
  • Test Code Formatting:

    • Improved import organization in JenkinsOpenTelemetryPluginConfigurationIntegrationTest.java by grouping static imports at the top. [1] [2]
    • Reformatted method chaining and brace placement for better readability in test helper method.
    • Simplified multi-line string assignment in JenkinsOtelPluginMBPIntegrationTest.java by removing unnecessary line breaks.

Copilot AI review requested due to automatic review settings January 18, 2026 19:44
@kuisathaverat kuisathaverat self-assigned this Jan 18, 2026
@kuisathaverat kuisathaverat mentioned this pull request Jan 18, 2026
6 tasks
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request applies automated code formatting fixes using the "Sportless" tool to improve code consistency and style across the codebase. The changes address formatting issues in test files and the POM configuration without modifying any functional behavior.

Changes:

  • Fixed string concatenation indentation and formatting in test code
  • Reordered imports to follow Java conventions (static imports first)
  • Improved method declaration formatting and line breaking
  • Corrected XML indentation and dependency ordering in POM

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
src/test/java/io/jenkins/plugins/opentelemetry/job/step/WithNewSpanStepTest.java Fixed indentation of string concatenation operator
src/test/java/io/jenkins/plugins/opentelemetry/JenkinsOtelPluginMBPIntegrationTest.java Consolidated text block declaration onto a single line
src/test/java/io/jenkins/plugins/opentelemetry/JenkinsOpenTelemetryPluginConfigurationIntegrationTest.java Reordered static imports, improved method formatting and line breaking, removed trailing blank line
pom.xml Fixed property indentation and reordered commons-lang3-api dependency for better organization

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@kuisathaverat kuisathaverat requested a review from v1v January 18, 2026 20:10
@kuisathaverat kuisathaverat merged commit 099b9f6 into jenkinsci:main Jan 19, 2026
17 checks passed
Comment on lines +198 to +201
<dependency>
<groupId>io.jenkins.plugins</groupId>
<artifactId>commons-lang3-api</artifactId>
</dependency>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to answer #1213 (comment):

This was not moved out of dependency management. Just reordered within the <dependencies/> tag. Removed line here (156-159) were not in dependency management.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants