Conversation
…me so build parameters are properly evaluated
Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>
Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>
Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>
Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>
I've also added substituteParameters(String, Node, AbstractProject, ...) to generalize non-build substitutions like checkouts. Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>
There was a problem hiding this comment.
Just a temporary solution to compile the code. I'll remove it and explicitly use MacroStringHelper.
The previous method was implementation private, hence there won't be any issues
|
plugins » perforce-plugin #105 SUCCESS |
There was a problem hiding this comment.
It was the unused variable
Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>
|
Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests |
All methods have been migrated to the new MacroStringHelper API. Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>
|
plugins » perforce-plugin #107 SUCCESS |
|
@rpetti The change would slightly corrupt the backward compatibility. Since it's just an Util class, such change seems to be acceptable. What do you think about it? |
|
I'm not sure how it would break any backwards compatibility, since it doesn't make use of any serialization methods, nor it is used by other plugins. I'd say go ahead and do what you feel is best. |
|
It breaks the binary compatibility. If someone uses its public methods in dependent plugins or Groovy scripts, such change will lead to the crash. BTW, the probability of such usage is close to 0% |
|
Yeah, nothing else should be using those Util classes, so it shouldn't break anything. |
Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>
All auxiliary methods in MacroStringHelper have been converted to private. Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>
|
plugins » perforce-plugin #108 SUCCESS |
…itution, etc Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>
Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>
|
plugins » perforce-plugin #111 SUCCESS |
Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>
Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>
|
plugins » perforce-plugin #114 SUCCESS |
…es_handling_refactoring Conflicts: src/main/java/hudson/plugins/perforce/PerforceSCM.java Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>
|
plugins » perforce-plugin #116 SUCCESS |
Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>
…nvironment Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>
Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>
|
plugins » perforce-plugin #118 SUCCESS |
Examples: (polling, workspace cleanup, etc) Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>
|
plugins » perforce-plugin #120 SUCCESS |
It is a follow-up to the discussion of f62db63 Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>
|
plugins » perforce-plugin #122 SUCCESS |
Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>
|
plugins » perforce-plugin #124 SUCCESS |
oleg-nenashev
changed the title
|
The request is ready for the final review |
|
Thanks a lot for working on this issue! I've been waiting for a fix a long time. We're desperate for building different Perforce branches in Matrix builds! Final question: When can we expect a new official version containing this fix? There was no release since January ...:/ |
|
@krizleebear
The current release approach presumes testing on @rpetti's development servers before the official release. Robert, would you like perform such testing? If no, I can use our infrastructure for the final testing. |
|
@oleg-nenashev |
|
I installed the .hpi in my testing environment. Unfortunately, I still get the error when configuring a BRANCH via configuration matrix: hudson.plugins.perforce.utils.ParameterSubstitutionException: <//mib2_com/${BRANCH}/sqlite3/CMakeLists.txt //WRK/test.txt>: Found unresolved macro at '//mib2_com/${BRANCH}/sqlite3/CMakeLists.txt //WRK/test.txt' My matrix contains only one axis: BRANCH=dev/work |
|
Could you reference an issue on JIRA with such feature request? |
|
@krizleebear |
|
Aaaah, well. This explains everything! Thanks for this hint. I was trying this with every new version of perforce plugin and was disappointed every single time ;-) BR |
Behavior: * MatrixConfiguration: Inject Values * MatrixProject: Inject the first value or empty string if it is not available Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>
|
plugins » perforce-plugin #126 SUCCESS |
|
I tested CloudBees build #126 and it works like a charm! Thanks for this extremely useful improvement! So now I'm really looking forward to the official release! :) |
|
Is there any schedule when this change will be merged to the official branch and when this will result in an updated release? |
|
@rpetti Thank you a lot for merging this change to master branch! If you need support testing this version in order to release, feel free to contact me. |
6 participants
This PR aims the improvement and the generalization of variables handling in PerforceSCM
Related Issues: