Fix potential state mismatch in graph overview#590
Merged
timja merged 3 commits intojenkinsci:mainfrom Feb 24, 2025
Merged
Conversation
timja
requested changes
Feb 18, 2025
src/main/frontend/pipeline-graph-view/pipeline-graph/main/PipelineGraph.tsx
Show resolved
Hide resolved
timja
approved these changes
Feb 24, 2025
Member
timja
left a comment
There was a problem hiding this comment.
Seems to work fine based on testing various states using complex smokes:
- slow pending branch, other branches with unstable and one with error, the error is shown.
- slow pending branch, other one with unstable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #327
This change fixes an issue where when a child stage completes, its status is incorrectly displayed on the parent stage in the graph overview.
This bug is particularly noticeable in the complexSmokes pipeline. While this approach seems reasonable given the available node data, it may not be the definitive solution. A second review would be helpful to confirm its correctness.
(In this before screen cap the state is that of

Branch A, which is incorrect, we overwrite the state to that oftopStage)Before:
After:

Testing done
Ran this change through the tests nestedStages, skippedParallel, syntheticStages, and complexSmokes, noticed no adverse effects.
Submitter checklist