Skip to content

Fix potential state mismatch in graph overview #590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timja merged 3 commits into from
Feb 24, 2025
Merged

Fix potential state mismatch in graph overview #590

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9184898
Fix state mismatch
mr-remington Feb 18, 2025
ffa459a
Prettier
timja Feb 18, 2025
c578795
Dont overwrite on regular stage view
mr-remington Feb 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion src/main/frontend/pipeline-graph-view/pipeline-graph/main/PipelineGraph.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import {
StageInfo,
} from "./PipelineGraphModel";
import { layoutGraph } from "./PipelineGraphLayout";

import { Result } from "./PipelineGraphModel";
import { Node, SelectionHighlight } from "./support/nodes";
import {
BigLabel,
Expand Down Expand Up @@ -162,8 +162,24 @@ export class PipelineGraph extends React.Component {

let nodes = [];
for (const column of nodeColumns) {
const topStageState = column.topStage?.state ?? Result.unknown;

for (const row of column.rows) {
for (const node of row) {
// If the topStage is still running but one of its child nodes has completed,
// the UI may incorrectly display the childs status instead of the topStages.
// To ensure consistency, override the nodes state with the topStages state.
// This issue is reproducible in the complexSmokes test.
if (
column.topStage &&
"stage" in node &&
node.stage &&
Array.isArray(column.topStage.children) &&
column.topStage.children.includes(node.stage)
) {
node.stage.state = topStageState;
}

nodes.push(node);
}
}
Expand Down