Merged
Conversation
basil
commented
Jun 5, 2025
|
|
||
| // Console output line | ||
| export const ConsoleLine = (props: ConsoleLineProps) => { | ||
| export const ConsoleLine = memo(function ConsoleLine(props: ConsoleLineProps) { |
Member
Author
There was a problem hiding this comment.
After wrapping the component with memo, the resulting component's name was not automatically inferred, causing ESLint to flag a "missing displayName" error. By defining the component with a named function rather than the arrow syntax, React infers the displayName automatically.
Member
|
(edited your description to not cause it to be closed on merge, wording isn't the best but otherwise GitHub would close it) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

A minor performance improvement, not enough to fix fully #823, but enough to be measurable in profiling so I thought I would submit it. See React documentation.
Testing done
With
I saw that previous lines were being re-rendered every time a new line appeared. With this PR, only new lines are rendered, which drastically reduced the number of log statements I saw from thousands to several hundred.
Submitter checklist