Skip to content

Memoize ConsoleLine #827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timja merged 1 commit into from
Jun 5, 2025
Merged

Memoize ConsoleLine #827

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/main/frontend/pipeline-console-view/pipeline-console/main/ConsoleLine.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { useEffect, useRef } from "react";
import { memo, useEffect, useRef } from "react";

import { makeReactChildren, tokenizeANSIString } from "./Ansi.tsx";

Expand All @@ -17,7 +17,7 @@ declare global {
}

// Console output line
export const ConsoleLine = (props: ConsoleLineProps) => {
export const ConsoleLine = memo(function ConsoleLine(props: ConsoleLineProps) {
Copy link
Member Author

@basil basil Jun 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After wrapping the component with memo, the resulting component's name was not automatically inferred, causing ESLint to flag a "missing displayName" error. By defining the component with a named function rather than the arrow syntax, React infers the displayName automatically.

Copy link
Contributor

@felipecrs felipecrs Jun 5, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. That's the exact same thing I did here:

image

const ref = useRef<HTMLDivElement>(null);
useEffect(() => {
const height = ref.current ? ref.current.getBoundingClientRect().height : 0;
Expand Down Expand Up @@ -66,4 +66,4 @@ export const ConsoleLine = (props: ConsoleLineProps) => {
</div>
</pre>
);
};
});