Skip to content

Conversation

@basil
Copy link
Member

@basil basil commented Jun 5, 2025

This is my attempt at a quick and dirty workaround for #823, since I wasn't able to fix it properly even with the help of an LLM, and I've run out of time to spend working on this plugin for the time being. If others find that this is helpful and the positives outweigh the negatives, great; if not, then this PR can simply be closed and I won't mind at all.

I simply removed the --pgv-offset-bottom variable and its associated calculation. The result isn't as visually appealing (it is at the very bottom, covering the Jenkins version), but at least it doesn't jump around. This PR doesn't seem to help the occasional flickering at all.

Fixes #823

Testing done

Light testing seemed to help, at least in my environment, but additional testing would be welcome.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests that demonstrate the feature works or the issue is fixed

@basil basil requested a review from a team as a code owner June 5, 2025 21:15
@basil basil added the bug Something isn't working label Jun 5, 2025
@janfaracik
Copy link
Member

janfaracik commented Jun 6, 2025

I've also got #729 in draft - works well in Chrome/Edge, but not in Safari/Firefox. Safari tech preview works but with some issues.

@felipecrs
Copy link
Contributor

chrome_ZiGnIXfYEV.mp4

Indeed this "fixes" the issue with the up/down buttons, and not the flickering (but it was mentioned it wouldn't).

@timja timja merged commit df00577 into jenkinsci:main Jun 12, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Up and down arrows move around during running build (page jumps a bit too)

4 participants