Skip to content

Up and down arrows move around during running build #828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timja merged 1 commit into from
Jun 12, 2025
Merged

Up and down arrows move around during running build #828

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/frontend/pipeline-console-view/pipeline-console/main/scroll-to-top-bottom.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
.pgv-scroll-to-top-bottom {
position: fixed;
bottom: calc(var(--section-padding) * 1 + (var(--pgv-offset-bottom, 0px)));
bottom: var(--section-padding);
right: calc(var(--section-padding) * 2);
display: flex;
gap: 0.375rem;
Expand Down
9 changes: 0 additions & 9 deletions src/main/frontend/pipeline-console-view/pipeline-console/main/scroll-to-top-bottom.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,15 +23,6 @@ export default function ScrollToTopBottom() {
setIsAtTop(atTop);
setIsAtBottom(atBottom);
setIsScrollable(scrollable);

// Distance from bottom
const distanceFromBottom = docHeight - (scrollTop + windowHeight);

// Only trigger the offset if we're within 20px from the bottom
const offset = Math.max(0, Math.min(100, 100 - distanceFromBottom));

const root = document.documentElement;
root.style.setProperty("--pgv-offset-bottom", `${offset}px`);
};

updateScrollState();
Expand Down