FlowExecution#getAuthentication2

[basil]

jenkinsci/jenkins#4848

[jglick]

Looks right. Is there a planned impl in https://github.com/jenkinsci/workflow-cps-plugin/blob/d58c465ea71a1d94b1ad827b885b1a5193c9adac/plugin/src/main/java/org/jenkinsci/plugins/workflow/cps/CpsFlowExecution.java#L1566-L1582 https://github.com/jenkinsci/workflow-cps-plugin/blob/d58c465ea71a1d94b1ad827b885b1a5193c9adac/plugin/src/main/java/org/jenkinsci/plugins/workflow/cps/CpsVmExecutorService.java#L172 ? (see jenkinsci/pipeline-plugin@9abf40a)

[basil]

@jglick Yes, such an implementation is planned but not currently assigned to any particular person.

[jglick]

That is fine but this should probably stay on hold until the downstream PR has been prepared, as it is technically introducing a new API.

[basil]

That is fine but this should probably stay on hold until the downstream PR has been prepared

jenkinsci/jenkins#4848 was not held back by the lack of downstream PRs (cf. jenkinsci/reverse-proxy-auth-plugin#153 (comment)), so I see no reason why this PR should stay on hold.

[jglick]

There were some; this method is both implemented and called in only one place (AFAIK), workflow-cps, so it only makes sense to evolve it in the context of those two sites.

(Actually workflow-cps could define and call getAuthentication2 even before it is defined in FlowExecution; it would only be the @Override annotation that would depend on this.)

[basil]

so it only makes sense to evolve it in the context of those two sites

Hence the plan to update those call sites eventually. Is there a particular reason that has to be done as a prerequisite to merging this PR?

[jglick]

Yes: matching changes should be prepared in advance where feasible. Filed jenkinsci/workflow-cps-plugin#1002 and will merge this if it passes tests.

[cyrille-leclerc]

This commit causes:

java.lang.IllegalArgumentException: The specified derived class (org.jenkinsci.plugins.workflow.cps.CpsFlowExecution) does not derive from the specified base class (org.springframework.security.core.Authentication).
	at hudson.Util.isOverridden(Util.java:1536)
	at hudson.Util.ifOverridden(Util.java:1564)
	at PluginClassLoader for workflow-api//org.jenkinsci.plugins.workflow.flow.FlowExecution.getAuthentication(FlowExecution.java:266)
	at PluginClassLoader for opentelemetry//io.jenkins.plugins.opentelemetry.job.MonitoringPipelineListener.onAtomicStep(MonitoringPipelineListener.java:209)

It's impacting the OpenTelemetry plugin:

• Exception in TracingPipelineListener#onBeforeAtomicStep : IllegalArgumentException: The specified derived class (...CpsFlowExecution) does not derive from the specified base class (...Authentication). opentelemetry-plugin#1064

[cyrille-leclerc]

@basil @jglick can you please check https://issues.jenkins.io/browse/JENKINS-75532

[basil]

⇨ #391

[cyrille-leclerc]

getClass() will return values like org.jenkinsci.plugins.workflow.cps.CpsFlowExecution which do NOT derive from org.springframework.security.core.Authentication