Skip to content

[JENKINS-75532] Fix compatibility layer#391

Merged
jglick merged 1 commit intojenkinsci:masterfrom
basil:JENKINS-75532
Apr 8, 2025
Merged

[JENKINS-75532] Fix compatibility layer#391
jglick merged 1 commit intojenkinsci:masterfrom
basil:JENKINS-75532

Conversation

@basil
Copy link
Member

@basil basil commented Apr 8, 2025

Amends #383.

Testing done

CI build. Also, with

diff --git a/plugin/src/test/java/org/jenkinsci/plugins/workflow/WorkflowTest.java b/plugin/src/test/java/org/jenkinsci/plugins/workflow/WorkflowTest.java
index 76181b3e..cf360839 100644
--- a/plugin/src/test/java/org/jenkinsci/plugins/workflow/WorkflowTest.java
+++ b/plugin/src/test/java/org/jenkinsci/plugins/workflow/WorkflowTest.java
@@ -205,7 +205,7 @@ public class WorkflowTest {
             @Override public void onResume() {
                 super.onResume();
                 try {
-                    listener.getLogger().println("again running as " + flow.getAuthentication2().getName() + " from " + Thread.currentThread().getName());
+                    listener.getLogger().println("again running as " + flow.getAuthentication().getName() + " from " + Thread.currentThread().getName());
                 } catch (Exception x) {
                     getContext().onFailure(x);
                 }

I was able to reproduce the problem running WorkflowTest#authentication. After this PR, could no longer reproduce.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@jglick jglick merged commit e334280 into jenkinsci:master Apr 8, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants