Add additional edge case tests for parseResultsPerPage#127
Open
machphy wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends unit test coverage around NvdCveClient.parseResultsPerPage() to validate additional edge cases in parsing the NVD error message and the fallback behavior when parsing fails.
Changes:
- Added a test to ensure parsing succeeds even when the error message does not end with a period.
- Added a test to verify the method falls back to the configured
resultsPerPagewhen the parsed suffix is not numeric.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+41
to
+43
| int recordsPerPage = client.parseResultsPerPage( | ||
| "resultsPerPage parameter cannot exceed abc." | ||
| ); |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Comment on lines
+41
to
+43
| int recordsPerPage = client.parseResultsPerPage( | ||
| "resultsPerPage parameter cannot exceed abc." | ||
| ); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds additional unit tests for
NvdCveClient.parseResultsPerPage().Changes:
All tests pass successfully.