Skip to content

Add additional edge case tests for parseResultsPerPage #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
machphy wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add additional edge case tests for parseResultsPerPage #127

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e64ac34
test: add additional parseResultsPerPage edge case tests
machphy Jun 23, 2026
f9b4328
Potential fix for pull request finding
machphy Jun 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 29 additions & 2 deletions src/test/java/io/github/jeremylong/openvulnerability/client/nvd/NvdCveClientTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,35 @@ class NvdCveClientTest {
void parseResultsPerPageTest() {
try (NvdCveClient client = new NvdCveClient(null, null, 1, 1)) {
client.setResultsPerPage(2000);
int recordsPerPage = client.parseResultsPerPage("resultsPerPage parameter cannot exceed 1000.");
assertEquals(1000, recordsPerPage, "Incorrect records per page value parsed");
int recordsPerPage = client.parseResultsPerPage(
"resultsPerPage parameter cannot exceed 1000.");
assertEquals(1000, recordsPerPage,
"Incorrect records per page value parsed");
}
}

@Test
void parseResultsPerPageInvalidNumberTest() {
try (NvdCveClient client = new NvdCveClient(null, null, 1, 1)) {
client.setResultsPerPage(2000);

int recordsPerPage = client.parseResultsPerPage(
"resultsPerPage parameter cannot exceed abc."
);
Comment on lines +41 to +43

assertEquals(2000, recordsPerPage,
"Should return configured resultsPerPage on parse failure");
}
}

@Test
void parseResultsPerPageWithoutPeriodTest() {
try (NvdCveClient client = new NvdCveClient(null, null, 1, 1)) {
int recordsPerPage = client.parseResultsPerPage(
"resultsPerPage parameter cannot exceed 500");

assertEquals(500, recordsPerPage,
"Incorrect records per page value parsed");
}
}
}
Loading