Put reference on executable object's this_binding to avoid unwanted f… #4966
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rees before exiting execution This patch fixes jerryscript-project#4870. JerryScript-DCO-1.0-Signed-off-by: Martin Negyokru [email protected]
rerobika
requested changes
Jan 14, 2022
|
|
||
| ecma_ref_if_object (executable_object_p->frame_ctx.this_binding); | ||
| ecma_value_t result = vm_execute (&executable_object_p->frame_ctx); | ||
| ecma_deref_if_object (executable_object_p->frame_ctx.this_binding); |
Member
There was a problem hiding this comment.
Is it okay to release if executable_object_p->frame_ctx.call_operation == VM_EXEC_RETURN? I think both the ref/and deref should be placed next to executable_object_p->iterator ref/deref.
gergocs
added a commit
to gergocs/jerryscript
that referenced
this pull request
Nov 19, 2024
…rees before exiting execution This patch fixes jerryscript-project#4870. The implementation is based on PR jerryscript-project#4966, only resolved the conflicts and applied requested changes. Co-authored-by: Martin Negyokru [email protected] JerryScript-DCO-1.0-Signed-off-by: Gergo Csizi [email protected]
gergocs
added a commit
to gergocs/jerryscript
that referenced
this pull request
Nov 19, 2024
…rees before exiting execution This patch fixes jerryscript-project#4870. The implementation is based on PR jerryscript-project#4966, only resolved the conflicts and applied requested changes. Co-authored-by: Martin Negyokru [email protected] JerryScript-DCO-1.0-Signed-off-by: Gergo Csizi [email protected]
gergocs
added a commit
to gergocs/jerryscript
that referenced
this pull request
Nov 19, 2024
…rees before exiting execution This patch fixes jerryscript-project#4870. The implementation is based on PR jerryscript-project#4966, only resolved the conflicts and applied requested changes. Co-authored-by: Martin Negyokru [email protected] JerryScript-DCO-1.0-Signed-off-by: Gergo Csizi [email protected]
robertsipka
pushed a commit
that referenced
this pull request
Nov 19, 2024
#5169) …rees before exiting execution This patch fixes #4870. The implementation is based on PR #4966, only resolved the conflicts and applied requested changes. Co-authored-by: Martin Negyokru [email protected] JerryScript-DCO-1.0-Signed-off-by: Gergo Csizi [email protected]
Contributor
|
Closing this PR, due it has been taken over and merged via PR5169 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rees before exiting execution
This patch fixes #4870.
JerryScript-DCO-1.0-Signed-off-by: Martin Negyokru [email protected]