-
Notifications
You must be signed in to change notification settings - Fork 686
Put reference on executable object's this_binding to avoid unwanted f… #4966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
mnegyokru
wants to merge
1
commit into
jerryscript-project:master
from
mnegyokru:fix_4870_promise_gc
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,87 @@ | ||
| // Copyright JS Foundation and other contributors, http://js.foundation | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| async function f() { | ||
| let arr = [0.000000]; | ||
| let fuzz_v152 = arr; | ||
| let fuzz_v159 = fuzz_v152.__proto__; | ||
| fuzz_v152.valueOf = function* (fuzz_v166, fuzz_v167) { | ||
| while (arr) { | ||
| } | ||
| var fuzz_v172 = ~f; | ||
| arr >>= [1.100000]; | ||
| return fuzz_v167; | ||
| }; | ||
| arr.includes(arr, [340282346638528859811704183484516925440.000000], arr); | ||
| delete [10]; | ||
| let fuzz_v253 = f.__proto__; | ||
| let fuzz_v256 = { | ||
| "D5FP8": f | ||
| }; | ||
| arr["map"](f, new Object(true)); | ||
| arr.flat(); | ||
| let fuzz_v69 = false; | ||
| await this; | ||
| await f; | ||
| var fuzz_v43 = arr -= new Date(new String({ | ||
| "findIndex": arr | ||
| })); | ||
| await this; | ||
| let fuzz_v286 = Symbol.reject(); | ||
| await f; | ||
| await new Promise(f); | ||
| await new Promise(async function* (fuzz_v80) { | ||
| var fuzz_v82 = new Uint32Array(fuzz_v80, arr, [1.100000], fuzz_v80, fuzz_v80); | ||
| let fuzz_v96 = fuzz_v82.__proto__; | ||
| this.length = 4; | ||
| }); | ||
| await new Promise(async function* (fuzz_v138, fuzz_v139) { | ||
| fuzz_v138.__proto__ = fuzz_v139; | ||
| let fuzz_v147 = function* (fuzz_v149, fuzz_v150, fuzz_v151, fuzz_v152) { | ||
| let fuzz_v165 = Reflect.apply(fuzz_v152, { | ||
| "findIndex": fuzz_v150 | ||
| }, [{}]); | ||
| switch ({ | ||
| includes: fuzz_v138, | ||
| set valueOf(fuzz_v175) { | ||
| fuzz_v150.valueOf = fuzz_v175; | ||
| return; | ||
| } | ||
| }) { | ||
| case [1.100000]: | ||
| throw arr; | ||
| break; | ||
| case 5643033980980220.000000: | ||
| let fuzz_v203 = String.prototype.trim.call(new String()); | ||
| break; | ||
| default: | ||
| fuzz_v43.valueOf = fuzz_v150; | ||
| } | ||
| let fuzz_v214 = fuzz_v69; | ||
| let fuzz_v223 = Number.isInteger(2147483648); | ||
| }; | ||
| var fuzz_v228 = f; | ||
| delete f.__proto__; | ||
| let fuzz_v237 = {}; | ||
| }); | ||
| await new Promise(f); | ||
| await new Promise(async function* (fuzz_v269, fuzz_v270, fuzz_v271) { | ||
| class fuzz_class273 extends f { | ||
|
|
||
| } | ||
| return arr; | ||
| }); | ||
| await new Promise(fuzz_v286); | ||
| } | ||
| f(f, f); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it okay to release if
executable_object_p->frame_ctx.call_operation == VM_EXEC_RETURN? I think both the ref/and deref should be placed next toexecutable_object_p->iteratorref/deref.