fix: migrate to new Excalidraw v0.18.0 #16392
Conversation
|
Hi, thanks for your contribution! |
package.json
Outdated
| "react-youtube": "10.1.0", | ||
| "redux": "4.0.4", | ||
| "redux-thunk": "2.4.1", | ||
| "roughjs": "^4.6.4", |
There was a problem hiding this comment.
Can we add a peer dependency for this in our package, rather than require ie be here?
| import React, { useCallback, useEffect, useRef } from 'react'; | ||
| import { WithTranslation } from 'react-i18next'; | ||
| import { useSelector } from 'react-redux'; | ||
| import "@jitsi/excalidraw/index.css"; |
There was a problem hiding this comment.
they have updated their implementation, figured this out after reading their docs, mentioned under excalidraw Wrapper, https://docs.excalidraw.com/docs/@excalidraw/excalidraw/integration
There was a problem hiding this comment.
For some reason in the Module Bundler example it doesn't import the CSS. Can you check if it works without it?
There was a problem hiding this comment.
No Saul, Whiteboard is not working, If I am removing this
There was a problem hiding this comment.
Can we import it in ExcalidrawApp instead?
webpack.config.js
Outdated
| }, { | ||
| test: /\.m?js$/, | ||
| resolve: { | ||
| fullySpecified: false |
There was a problem hiding this comment.
this makes module imports more flexible and prevents build errors from incomplete import path, which are present in the excalidraw codebase
There was a problem hiding this comment.
Is it possible to apply that to the Excalidraw package only?
Does disabling chunking on the build help in any way?
There was a problem hiding this comment.
Removed roughjs from the project dependencies and also removed this part of the code
Added roughjs as a dependency inside the excalidraw package, and configured an alias for roughjs in the webpack file, since Excalidraw was using incomplete import paths from roughjs folders
| theme: 'light', | ||
| UIOptions: WHITEBOARD_UI_OPTIONS | ||
| UIOptions: { | ||
| ...WHITEBOARD_UI_OPTIONS |
| import React, { useCallback, useEffect, useRef } from 'react'; | ||
| import { WithTranslation } from 'react-i18next'; | ||
| import { useSelector } from 'react-redux'; | ||
| import "@jitsi/excalidraw/index.css"; |
There was a problem hiding this comment.
Can we import it in ExcalidrawApp instead?
|
This is a really exciting update. Any idea on if it can be completed ? Happy to help if needed. |
|
We are almost there, it's a GSoC project. |
|
show error: |
|
Hey @jiyeyuran, work is in progress for the new excalidraw, in the latest version Firebase will be replaced with the S3 compatible backend for storage |
OK,I thought the latest tag 0.18.1 is stable.It seems that jitsi/excalidraw needs some options to let users provide the getFiles and saveFiles methods for FileManager. |
5 participants
This PR upgrades the whiteboard integration in Jitsi Meet to use the latest Excalidraw release jitsi/excalidraw#8