-
Notifications
You must be signed in to change notification settings - Fork 750
Docs: Organize community_tools.md into sections of tool types #7786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…d Judo This organizes the list into tool types a bit since the list is a bit long at this point, and also adds the new Judo tool. Feel free to suggest any ordering/organization changes, this was just my first intuition of the tool grouping.
What is it based on? I thought it was alphabetical at first but at least GG and Selvejj are out of order. |
Should probably be two commits, one organizing and one adding the tool |
I'm raising this concern respectfully, and apologize for not having a HN account to respond directly to Martin's comment here. I have some reservations about listing
Given that |
As I've said on the Discord, at this point it probably is worth it to introduce tool categories. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The following commits do not follow our format for subject lines:
- ad10c02: Update community_tools.md
Commits should have a subject line following the format <topic>: <description>
. Please review the commit guidelines for more information.
I've made the following changes:
|
All commits are now correctly formatted. Thank you for your contribution!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor stuff, I also don't think you should move your addition to a separate PR so removing your addition in the second commit is unnecessary to me
@@ -1,18 +1,10 @@ | |||
# Community-built tools around Jujutsu | |||
# Community-built tools around Jujutsu (alphabetical) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: I don't think adding this to the title helps, since you know it when you see it
Addressed the comments and re-added the tool |
see https://jj-vcs.github.io/jj/prerelease/contributing/#code-reviews for more info on how the project does code review. |
Thanks, let me know if I put the commits in the proper format |
I would not dare install it myself (sorry, nothing against you specifically, @JudoJJ) but it sounds like many people worry less than I do. Should we just add a disclaimer saying that we don't take responsibility for these tools? |
This is a community page, we neither endorse or dismiss certain tools by having them here. But we need to say that at some point somewhere. |
This organizes the list into tool types a bit since the list is a bit long at this point, and also adds the new Judo tool. Feel free to suggest any ordering/organization changes, this was just my first intuition of the tool grouping.