Fix: ensure default providers are not mutated in factory.py (#2311)#2313
Closed
sathvik70004-cmyk wants to merge 1 commit intojoke2k:masterfrom
Closed
Fix: ensure default providers are not mutated in factory.py (#2311)#2313sathvik70004-cmyk wants to merge 1 commit intojoke2k:masterfrom
sathvik70004-cmyk wants to merge 1 commit intojoke2k:masterfrom
Conversation
Contributor
|
I guess that this should have a test as well to avoid this side effect in the future. |
fcurella
reviewed
Feb 23, 2026
Collaborator
fcurella
left a comment
fcurella
left a comment
There was a problem hiding this comment.
I dont see how this change modifies any behavior
5 tasks
fcurella
reviewed
Mar 12, 2026
| providers = providers or PROVIDERS | ||
|
|
||
| providers += includes | ||
| providers = providers+includes |
Collaborator
There was a problem hiding this comment.
I think the AI might be hallucinating here. I don't see how the change would prevent mutation. If it does, please add a comment explaining.
3 tasks
Collaborator
|
Closed in a801a34 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change
Brief summary of the changes.
What was wrong
Description of the root cause of the issue.
How this fixes it
Description of how the changes fix the issue.
Fixes #...
Checklist
make lint