fix: prevent mutation of global PROVIDERS list in Factory.create#2331
Closed
GitMike01 wants to merge 1 commit intojoke2k:masterfrom
Closed
fix: prevent mutation of global PROVIDERS list in Factory.create#2331GitMike01 wants to merge 1 commit intojoke2k:masterfrom
GitMike01 wants to merge 1 commit intojoke2k:masterfrom
Conversation
3 tasks
fcurella
reviewed
Mar 12, 2026
| providers = providers or PROVIDERS | ||
|
|
||
| providers += includes | ||
| providers = providers + includes |
Collaborator
There was a problem hiding this comment.
I think the AI might be hallucinating here. I don't see how the change would prevent mutation. If it does, please add a comment explaining.
Collaborator
|
Duplicate of #2313 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change
Changed the way providers and includes are combined in Factory.create to ensure the original list is not modified
What was wrong
The code was using the in-place addition operator (+=) on the providers list. When providers defaulted to the global PROVIDERS constant, this operator mutated the global list itself. This caused side effects where subsequent Faker instances would unexpectedly contain providers from previous instances
How this fixes it
Replaced the in-place operator += with the concatenation operator +. This creates a new list for the local scope of the function, leaving the global PROVIDERS constant intact and preventing unintended side effects.
Fixes #2311
AI Assistance Disclosure (REQUIRED)
Checklist
make lint