Skip to content

Comments

[5.4] Reduce exclusions in phpstan-baseline.neon#46857

Merged
richard67 merged 2 commits intojoomla:5.4-devfrom
richard67:5.4-dev-update-phpstan-baseline-2026-02-08
Feb 17, 2026
Merged

[5.4] Reduce exclusions in phpstan-baseline.neon#46857
richard67 merged 2 commits intojoomla:5.4-devfrom
richard67:5.4-dev-update-phpstan-baseline-2026-02-08

Conversation

@richard67
Copy link
Member

@richard67 richard67 commented Feb 8, 2026

Pull Request for Issue # .

Summary of Changes

This pull request (PR) adapts the phpstan-baseline.neon to recent fixes in the code base so that the number of some exclusions are reduced.

By reducing the numbers we make sure that no new PHPstan errors of this kind will be added to the same files by mistake with some new code.

Testing Instructions

  1. Code review: Check that this PR does not add any new stuff, it only reduces the number of exclusions at 2 places.
  2. Check that the GitHub action for the PHPstan check succeeds.

Actual result BEFORE applying this Pull Request

PHPstan succeeds, but the number of occurrences for 2 exclusions is larger than necessary.

Expected result AFTER applying this Pull Request

PHPstan succeeds, and the number of occurrences for 2 exclusions has been reduced.

Link to documentations

Please select:

  • Documentation link for guide.joomla.org:

  • No documentation changes for guide.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@richard67 richard67 changed the title [4.3] Reduce exclusions in phpstan-baseline.neon [5.4] Reduce exclusions in phpstan-baseline.neon Feb 8, 2026
Copy link
Contributor

@muhme muhme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Only numbers are changed
  • GitHub phpstan successfully
  • libraries/vendor/bin/phpstan analyse --generate-baseline and found the same two numbers

@richard67 richard67 merged commit ae05f46 into joomla:5.4-dev Feb 17, 2026
69 checks passed
@richard67 richard67 deleted the 5.4-dev-update-phpstan-baseline-2026-02-08 branch February 17, 2026 18:25
@richard67 richard67 added this to the Joomla! 5.4.4 milestone Feb 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants