[5.4] Reduce exclusions in phpstan-baseline.neon#46857
Merged
richard67 merged 2 commits intojoomla:5.4-devfrom Feb 17, 2026
Merged
[5.4] Reduce exclusions in phpstan-baseline.neon#46857richard67 merged 2 commits intojoomla:5.4-devfrom
richard67 merged 2 commits intojoomla:5.4-devfrom
Conversation
4 tasks
muhme
approved these changes
Feb 17, 2026
Contributor
muhme
left a comment
There was a problem hiding this comment.
- Only numbers are changed
- GitHub
phpstansuccessfully libraries/vendor/bin/phpstan analyse --generate-baselineand found the same two numbers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
This pull request (PR) adapts the
phpstan-baseline.neonto recent fixes in the code base so that the number of some exclusions are reduced.By reducing the numbers we make sure that no new PHPstan errors of this kind will be added to the same files by mistake with some new code.
Testing Instructions
Actual result BEFORE applying this Pull Request
PHPstan succeeds, but the number of occurrences for 2 exclusions is larger than necessary.
Expected result AFTER applying this Pull Request
PHPstan succeeds, and the number of occurrences for 2 exclusions has been reduced.
Link to documentations
Please select:
Documentation link for guide.joomla.org:
No documentation changes for guide.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed