fix: remove score validation bounds to support raw logits from cross-encoder #17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ms-marco-MiniLM-L-6-v2)-1.0to1.0constraint on rerank scores that was blocking legitimate model outputsProblem
The current code enforces score bounds (
ge=-1.0, le=1.0) inRerankResult, which causes validation errors with standard cross-encoder models that output raw logits (e.g., scores like7.45or-2.3). This breaks reranking functionality with industry-standard models.Solution
ge=-1.0, le=1.0constraints fromRerankResult.scorefieldOPENAI_RERANK_AUTO_SIGMOID=trueTesting
Tested with
cross-encoder/ms-marco-MiniLM-L-6-v2on macOS Apple Silicon:Impact