Skip to content

fix: remove score validation bounds to support raw logits from cross-encoder #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joonsoome merged 1 commit into from
Dec 23, 2025
Merged

fix: remove score validation bounds to support raw logits from cross-encoder #17

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions app/models/responses.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,8 @@ class EmbedResponse(BaseModel):
"""Response model for embedding generation."""

model_config = ConfigDict(
json_encoders={datetime: lambda v: v.isoformat()}, protected_namespaces=() # Allow model_ fields
json_encoders={datetime: lambda v: v.isoformat()},
protected_namespaces=(), # Allow model_ fields
)

# Enhanced structure with both new format and backward compatibility
Expand Down Expand Up @@ -74,9 +75,7 @@ class RerankResult(BaseModel):
)
score: float = Field(
...,
description="Relevance score (higher is more relevant, can be negative for similarity methods)",
ge=-1.0,
le=1.0,
description="Relevance score (higher is more relevant, raw logits from model or normalized based on client request)",
json_schema_extra={"example": 0.8542},
)
index: int = Field(..., description="Original index in input list", ge=0, json_schema_extra={"example": 0})
Expand All @@ -86,7 +85,8 @@ class RerankResponse(BaseModel):
"""Response model for document reranking."""

model_config = ConfigDict(
json_encoders={datetime: lambda v: v.isoformat()}, protected_namespaces=() # Allow model_ fields
json_encoders={datetime: lambda v: v.isoformat()},
protected_namespaces=(), # Allow model_ fields
)

results: List[RerankResult] = Field(
Expand Down
Loading