Fix global handling of current tally data #718
+28
−59
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During implementation of SimplyLive source (#717), i noticed some strange behaviour.
E.g. the tally state in the UI was not matching the state in the VMix emulator.
I traced it to some inconsistencies in the tally state update and linked bus logic.
This PR should fix any updateDevice logic and get rid of duplicated code for linked bus logic. This relies on the internal state which is computed by "UpdateDevice" to be accurate and can be used as SSOT for all other places where the current tally state of a device is used.