WIP: Connect Robot Modules #462
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arntanguy
force-pushed
the
topic/ConnectModules
branch
2 times, most recently
from
1c74a2e to
d01c46e
Compare
arntanguy
force-pushed
the
topic/ConnectModules
branch
2 times, most recently
from
86176af to
b75be1f
Compare
arntanguy
force-pushed
the
topic/ConnectModules
branch
from
b75be1f to
4cf8b27
Compare
This method allows to generate a new RobotModule by connecting two modules together.
for more information, see https://pre-commit.ci
Boost 1.74 has a bug in bfs::copy_path, use std::filesystem instead
The introduction of RobotModule::connect made it interesting to compose robot modules. In order to expose new modules that are composed of multiple other existing modules, it is necessary to allow loading other robot modules while creating a new one. This effectively allows calling get_robot_module from within the create() function of a new robot module library. To do so we unlock the mutex just before the actual call to create(). This may have unintended side effects.
arntanguy
force-pushed
the
topic/ConnectModules
branch
from
4cf8b27 to
c756be4
Compare
for more information, see https://pre-commit.ci
jointConfig for a free joint is a 0-matrix, thus the transform is a zero matrix. This messes up the root joint's inertia and such.
For now we do not generate a connected robot module using the real urdf paths, we probably should. To support display as-is in ROS, we use the control urdf as real urdf.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a rebased from Pierre's work on connecting robot modules together.