Added new test suites in emaail validation of the format.json file of…#869
Open
sahajsrivastava044-spec wants to merge 2 commits intojson-schema-org:mainfrom
Open
Conversation
… the draft3 in test file along python enviroment variables.
jviotti
reviewed
Mar 9, 2026
| "data": null, | ||
| "valid": true | ||
| } | ||
|
|
jviotti
reviewed
Mar 9, 2026
jviotti
reviewed
Mar 9, 2026
jviotti
reviewed
Mar 9, 2026
Member
|
Please don't add any implementation setup in this repo. It is supposed to be an implementation agnostic test suite. |
jviotti
reviewed
Mar 9, 2026
| }, | ||
| { | ||
| "description": "Invalid email with no spec interpretation", | ||
| "data": "user@localhost", |
Member
There was a problem hiding this comment.
I don't think this is invalid as per the RFC
jviotti
reviewed
Mar 9, 2026
| }, | ||
| { | ||
| "description": "Invalid email with unwanted special symbols", | ||
| "data": "user//@example.com", |
Member
There was a problem hiding this comment.
I think this is valid as per the RFC too
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/tests/draft3/format.jsonunder the "email format" section.Additionally:
run_suite.pyandstrict_email_validator.py) to test both spec-compliant and stricter email validation.This contribution ensures the test suite better reflects problematic email cases, while keeping spec compliance clear.