Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this file being edited?

Original file line number Diff line number Diff line change
Expand Up @@ -158,3 +158,4 @@ cython_debug/
# and can be added to the global gitignore or merged into this file. For a more nuclear
# option (not recommended) you can uncomment the following to ignore the entire idea folder.
#.idea/
sandbox
25 changes: 25 additions & 0 deletions package-lock.json
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this file being edited?

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 4 additions & 1 deletion package.json
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this file being edited?

Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,8 @@
"tests"
],
"author": "http://json-schema.org",
"license": "MIT"
"license": "MIT",
"dependencies": {
"jsonschema": "^1.5.0"
}
}
26 changes: 26 additions & 0 deletions tests/draft3/format.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,31 @@
"description": "all string formats ignore nulls",
"data": null,
"valid": true
},
{
"description": "User with double dot in email",
"data": "[email protected]",
"valid": false
},
{
"description": "User uses a specific domain",
"data": "user@",
"valid": false
},
{
"description": "Invalid email with space",
"data": "user [email protected]",
"valid": false
},
{
"description": "Invalid email with no spec interpretation",
"data": "user@localhost",
Copy link
Member

@jviotti jviotti Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is invalid as per the RFC

"valid": false
},
{
"description": "Invalid email with unwanted special symbols",
"data": "user//@example.com",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is valid as per the RFC too

"valid": false
}
]
},
Expand Down Expand Up @@ -69,6 +94,7 @@
"data": null,
"valid": true
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unintended change?

]
},
{
Expand Down
Loading