Fix incorrect handling of non-paginated repositories in fetchFirstCommitDate function#17
Open
haya08 wants to merge 1 commit intojson-schema-org:mainfrom
Open
Fix incorrect handling of non-paginated repositories in fetchFirstCommitDate function#17haya08 wants to merge 1 commit intojson-schema-org:mainfrom
haya08 wants to merge 1 commit intojson-schema-org:mainfrom
Conversation
Author
|
@Relequestual can you please review this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a logic issue in fetchFirstCommitDate function where repositories without pagination (i.e., repositories whose commits fit within a single page) were not handled correctly.
Problem
In the previous implementation, when the Link header was absent (indicating no pagination), the function accessed the commit date but did not return it:
response.data[0].commit.author.date;Solution
The updated implementation:
This guarantees correct behavior for:
Impact
This change improves the reliability of first commit date extraction and prevents false failures when processing repositories without pagination.