Skip to content

Fix incorrect handling of non-paginated repositories in fetchFirstCommitDate function #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
haya08 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix incorrect handling of non-paginated repositories in fetchFirstCommitDate function #17

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 18 additions & 12 deletions projects/initial-data/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,37 +16,43 @@ export async function fetchRepoCreationDate(octokit, owner, repo) {

async function fetchFirstCommitDate(octokit, owner, repo) {
console.log(`Fetching first commit date for repository: ${owner}/${repo}`);

try {
const response = await octokit.request(
'GET /repos/{owner}/{repo}/commits',
{
owner,
repo,
per_page: 1,
},
}
);

const lastPageUrl = response.headers.link?.match(
/<([^>]+)>;\s*rel="last"/,
)?.[1];
const linkHeader = response.headers.link;

const lastPageUrl = linkHeader
? linkHeader.match(/<([^>]+)>;\s*rel="last"/)?.[1]
: null;

if (!lastPageUrl) {
if (response.data.length > 0) {
response.data[0].commit.author.date;
} else {
if (response.data.length === 0) {
throw new Error(`No commits found for ${owner}/${repo}`);
}

return Date.parse(response.data[0].commit.author.date);
}

const lastPageResponse = await octokit.request(lastPageUrl);

if (lastPageResponse.data.length > 0) {
return Date.parse(lastPageResponse.data[0].commit.author.date);
} else {
throw new Error(`No commits found ${owner}/${repo}`);
if (lastPageResponse.data.length === 0) {
throw new Error(`No commits found for ${owner}/${repo}`);
}

return Date.parse(lastPageResponse.data[0].commit.author.date);

} catch (err) {
throw new Error(`Could not find any commits for ${owner}/${repo}`);
throw new Error(
`Failed to fetch first commit for ${owner}/${repo}: ${err.message}`
);
}
}

Expand Down